Skip to content

feat(sdk-coin-canton): add participant allow-list command builders - #10001

Merged
ravibitgo merged 1 commit into
masterfrom
CHALO-1850
Oct 19, 2026
Merged

ravibitgo merged 1 commit into
masterfrom
CHALO-1850

Conversation

@ravibitgo

Copy link
Copy Markdown
Contributor

Summary

Add typed BitGoJS/account-lib helpers for constructing DTCC Canton v3 participant allow-list commands.

Changes

  • Add CantonAllowListCommandParams.
  • Add CantonCommandBuilder.addWalletsToAllowList().
  • Add CantonCommandBuilder.removeWalletsFromAllowList().
  • Build the exact V3 Canton choices:
    • ParticipantService_AddWalletsToAllowList
    • ParticipantService_RemoveWalletsFromAllowList
  • Construct ExerciseCommand payloads using:
    • the ParticipantService template ID;
    • the ParticipantService contract CID;
    • the participant-owned allow-list CID;
    • end-investor credential CIDs.
  • Validate template, ParticipantService, and allow-list contract identifiers.
  • Reject empty or duplicate credential IDs.
  • Preserve the DAR-supported empty credential-list no-op behavior.
  • Keep the existing generic CantonCommand transaction type and signing flow unchanged.

Testing

  • Canton command builder tests: 367 passing.
  • Added coverage for:
    • add command construction;
    • remove command construction;
    • empty credential-list behavior;
    • duplicate credential rejection;
    • missing contract identifier rejection.
  • Prettier check passes.

The full package build currently reaches unrelated existing sdk-core VRF/MPC type and API errors outside this change.

Ticket: CHALO-1850

@linear-code

linear-code Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

CHALO-1850

@ravibitgo
ravibitgo marked this pull request as ready for review October 19, 2026 08:32
@ravibitgo
ravibitgo requested a review from a team as a code owner October 19, 2026 08:32
@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

@ravibitgo
ravibitgo merged commit 3eac65f into master Oct 19, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants