Repository navigation
Conversation
gerau
marked this pull request as draft
October 27, 2026 14:02
gerau
force-pushed
the
feat/feature-gate-smplx-test
branch
2 times, most recently
from
October 27, 2026 14:52
335ecbd to
dc09b5b
Compare
gerau
commented
Oct 27, 2026
| Add `smplx-std` dependency to cargo: | ||
|
|
||
| ```bash | ||
| cargo add --dev smplx-std |
Author
There was a problem hiding this comment.
Should we change this to
cargo add smplx-std --no-default-features
cargo add --dev smplx-std --features test?
I think it would be nice to have this behavior by default
Author
There was a problem hiding this comment.
This is an optional change which would be nice to add, so simplex init would have this structure by default. Though I could drop it if it is too much
Collaborator
There was a problem hiding this comment.
By now, Cargo.toml on initialisation has changed from
[dependencies]
smplx-std = "0.1.1"
to
[dependencies]
smplx-std = { version = "0.1.1", default-features = false }
[dev-dependencies]
smplx-std = { version = "0.1.1", features = ["test"] }
gerau
marked this pull request as ready for review
October 27, 2026 15:05
gerau
force-pushed
the
feat/feature-gate-smplx-test
branch
from
October 30, 2026 17:48
dc09b5b to
e4ab0bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #189.