Repository navigation
Conversation
- Replace AsyncAPI.sln with AsyncAPI.slnx (generated via `dotnet sln migrate`). - Add Directory.Packages.props and drop Version attributes from all src/test PackageReferences; versions are unchanged. - Opt the example projects out of CPM, since they float on published prerelease packages. - Point CI restore explicitly at AsyncAPI.slnx. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
Microsoft.SourceLink.GitHub 8.0.0 pulled in Microsoft.Build.Tasks.Git 8.0.0 (GHSA-23fw-v26w-5fgq, moderate). Microsoft.NET.Test.Sdk 16.11.0 pulled in Newtonsoft.Json 9.0.1 (GHSA-5crp-9r3c-p9vr, high). dotnet list package --vulnerable now reports none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
AsyncAPI.slnwithAsyncAPI.slnx, generated withdotnet sln migrate. It has the same 4 projects and solution items, andDirectory.Packages.propsis added to the solution items.Directory.Packages.propswithManagePackageVersionsCentrally=trueand removesVersionfrom everyPackageReferenceinsrc/andtest/. No package versions change.examples/projects opt out of CPM (ManagePackageVersionsCentrally=false). They aren't in the solution and use floating or prerelease versions of published packages (*-*), which CPM rejects unless floating versions are enabled.dotnet restore AsyncAPI.slnxexplicitly..slnxneeds SDK 9.0.200+, and CI already installs 10.0.x.Verification
dotnet build AsyncAPI.slnxsucceeds with the same warnings as before.dotnet test AsyncAPI.slnx: 318/318 pass on net8.0, net9.0 and net10.0.dotnet pack src/ByteBard.AsyncAPI.Readersgives the same nuspec dependencies (JsonPointer.Net 5.3.1,YamlDotNet 13.0.1,System.Text.Json 9.0.1on netstandard only)..csprojfiles, so they don't need changes.Note: the example projects already fail to restore on
vnextbecause they referenceByteBard.AsyncAPI.Readersinstead ofByteBard.AsyncAPI.NET.Readers. This PR doesn't change that.Vulnerable dependencies
With versions now in one place, this also bumps two packages flagged by
dotnet list package --vulnerable --include-transitive:Microsoft.SourceLink.GitHubMicrosoft.Build.Tasks.Git8.0.0 (GHSA-23fw-v26w-5fgq, moderate)Microsoft.NET.Test.SdkNewtonsoft.Json9.0.1 (GHSA-5crp-9r3c-p9vr, high)The scan now reports no vulnerable packages.
🤖 Generated with Claude Code
Summary by CodeRabbit