Repository navigation
Conversation
…resolved - Integer, long and bool scalar errors now include the value and the reason (not a whole number vs. out of range) and the location of the field. Schema integer fields used a catch-all that reported every failure as "The value is out of range"; they now use the same helper. - A reference whose document cannot be read now reports the underlying error, and a failed reference is no longer reported twice (once with the specific reason, then again as "Unable to deserialize reference"). - JsonPointer.Find no longer swallows exceptions. It also returned the scalar it walked into for pointers such as /info/title/nested instead of null. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Several reader errors hid what actually went wrong:
maxLength,minItems, …) used a catch-all that reported every failure asThe value is out of range., includingabcand1.5.Value could not parse to integer.without the value or the field location.Unable to deserialize referencewithout the cause (barecatch), and any failed reference was reported twice: once with the specific reason, then again generically.JsonPointer.Findswallowed all exceptions, and for a pointer that walks into a scalar (/info/title/nested) it returned the scalar instead ofnull.Change
Value 'abc' could not parse to integer. Expected a whole number.orValue '99999999999' could not parse to integer. It must be between -2147483648 and 2147483647., with the field's pointer. Schema integer fields use the same helper. The existing "could not parse to …" wording is kept.JsonPointer.Findchecks array bounds and node kinds instead of catching exceptions.Tests
ReaderErrorDetails_Should: 6 of its 9 tests fail onvnext. Full suite passes on net8.0/net9.0/net10.0.🤖 Generated with Claude Code