Repository navigation
fix: correct typos in two error messages - #490
Open
Avicennasis wants to merge 1 commit into
Open
Avicennasis wants to merge 1 commit into
Avicennasis wants to merge 1 commit into
Conversation
Signed-off-by: Léon Avic Simmons <Avicennasis@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two typos in user-visible error messages:
src-tauri/src/app/webview.rs:Download view was closed unexpected→Download view was closed unexpectedly(matchesMicrosoft sign-in window was closed unexpectedly.in the same file)src-tauri/src/app/gui/commands/client.rs:An error occured:→An error occurred:Both are string-literal changes only. The texts show up in the error context and the log view, and nothing matches on them. No other behaviour changes.
Also noticed: the doc comment on
sys_memory()insrc-tauri/src/utils/sys.rsends mid-sentence (Get the total memory of the system in). It is left alone, since the intended unit is yours to state.