Repository navigation
Make the Fleet Dashboard the first tab and the default landing view - #72
Merged
Merged
Conversation
The Fleet (Summary) Dashboard is now always present as the first tab and is the default action, so the Host MIB interface opens on it. The per-device Dashboard tab remains gated on being opened from its Devices-tab glyph.
TheWitness
requested review from
bmfmancini and
xmacan
and
a balanced review from Copilot
October 11, 2026 20:51
There was a problem hiding this comment.
🟡 Changes recommended
The new default action lacks a corresponding Cacti navigation entry, breaking breadcrumb/title resolution.
2 open findings
What changed in this PR
Makes the Fleet Dashboard the Host MIB interface’s first tab and default view.
Changes:
- Defaults action-less requests to
summary_dashboard. - Makes Fleet Dashboard permanently visible and first.
- Updates documentation and changelog.
| File | Description |
|---|---|
hmib.php |
Changes default landing view and tab ordering. |
CHANGELOG.md |
Records the feature. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bmfmancini
approved these changes
Oct 12, 2026
xmacan
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the Fleet (Summary) Dashboard the first tab and the default landing view of the Host MIB interface.
set_default_action('summary')→set_default_action('summary_dashboard'), so opening the plugin with no action lands on the Fleet Dashboard.hmib_tabs(), the Fleet Dashboard is now the first entry in the tab list and is always present (previously it only appeared after being opened from the Summary tab's dashboard glyph, or when a summary scope had been remembered).With no remembered OS-type scope, the Fleet Dashboard resolves to all devices (
ostype = -1), so the default landing view renders correctly out of the box.Notes
Fleet Dashboardlabel already existed), solocales/po/cacti.potis unchanged.manifest.jsonis unchanged.php -lclean. Two docblocks updated for accuracy (the default-view note moved fromhmib_summary()tohmib_summary_dashboard()).