Repository navigation
Theme-appropriate panel titlebar severity palettes across all themes - #421
Merged
Merged
Conversation
The green/orange/red titlebar severity colors were a single generic set copy-pasted into every theme file (garish kelly or drab olive green, black text on mid-green, pure yellow on midwinter/sunrise), so only deepness looked theme-appropriate. Tune each theme's green (good), orange (warning) and red (bad) to legible, theme-matched tones with correct text contrast, deepened for dark themes and brightened notification bubbles. Grey (unknown) stays neutral; deepness is unchanged.
TheWitness
requested review from
bmfmancini and
xmacan
and
a balanced review from Copilot
October 9, 2026 20:24
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Green titlebars in four themes remain below the WCAG AA contrast threshold.
4 open findings
What changed in this PR
Updates severity titlebar and notification colors to better match each Cacti theme.
Changes:
- Introduces distinct light, dark, and Sunrise severity palettes.
- Improves titlebar text and notification-bubble visibility.
- Documents the palette update.
| File | Description |
|---|---|
CHANGELOG.md |
Documents the theme palette update. |
css/cacti.css |
Applies the light-theme palette. |
css/carrot.css |
Applies the light-theme palette. |
css/classic.css |
Applies the light-theme palette. |
css/dark.css |
Applies the dark-theme palette. |
css/hollyberry.css |
Applies the light-theme palette. |
css/midwinter.css |
Applies the dark-theme palette. |
css/modern.css |
Applies the light-theme palette. |
css/paper-plane.css |
Applies the dark-theme palette. |
css/paw.css |
Applies the light-theme palette. |
css/raspberry.css |
Applies the light-theme palette. |
css/sunrise.css |
Applies a Sunrise-specific palette. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
#2e8b45 (and sunrise #3C8A3C) gave only 4.29:1 against white title text. Deepen to #2a8040 (4.93:1) for dark/midwinter/paper-plane and #348034 (4.90:1) for sunrise, keeping each theme's green hue.
cigamit
approved these changes
Oct 9, 2026
bmfmancini
approved these changes
Oct 9, 2026
bmfmancini
approved these changes
Oct 9, 2026
xmacan
approved these changes
Oct 10, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The panel titlebar severity colors (green = good, orange/yellow = warning,
red = bad, grey = unknown) were supposed to be theme-appropriate per theme.
In practice a single generic palette was copy-pasted into almost every theme
file, so only
deepnessactually looked right. Onmodernand the rest thetitlebars were garish or off:
rgba(40,180,40)(modern, paw) or a drabolive
rgba(148,179,107)(cacti, carrot, classic, dark, hollyberry,paper-plane, raspberry) - and in both cases used black text on a
mid-green bar (low contrast).
yellowonmidwinter/sunrise.Fix
Give each theme a legible, theme-appropriate severity palette while keeping
the semantics intact - green still reads green, orange reads orange/warning,
red reads red:
paw): forest green
#2e7d32with white text, red#c62828, warning#e08a1e.#2e8b45,brick red
#b3261e, amber#d9871a/#e0a81e, with brighter notificationbubbles (
#4caf79/#ff6b6b/#ff9e3d) so they pop against the dark panels.#3C8A3Cgreen, with the dark-theme red/ambertreatment and a brighter green bubble.
the lighter amber/grey bars).
#a1a1a1on every theme.No markup, PHP, or JS changes - CSS only. Brace balance verified for every
edited file;
deepness.cssuntouched.