Repository navigation
issue: shorten syslog graph drilldown button title to 'Syslog' - #411
Closed
TheWitness wants to merge 1 commit into
Closed
TheWitness wants to merge 1 commit into
TheWitness wants to merge 1 commit into
Conversation
The graph action menu now renders each drilldown button's title as a visible label, so 'Display Syslog in Range' reads as an overlong menu entry. Shorten it to 'Syslog' and regenerate locales/po/cacti.pot for the removed translatable string.
TheWitness
requested review from
bmfmancini and
xmacan
and
a balanced review from Copilot
October 12, 2026 20:18
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The regenerated POT file incorrectly removes its package version metadata.
1 open finding
What changed in this PR
Shortens the graph drilldown label to “Syslog” and updates related metadata.
Changes:
- Renames the graph button title.
- Updates gettext template and changelog.
| File | Description |
|---|---|
includes/navigation.php |
Shortens the drilldown title. |
locales/po/cacti.pot |
Removes the obsolete msgid. |
CHANGELOG.md |
Documents the change. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| msgid "" | ||
| msgstr "" | ||
| "Project-Id-Version: Cacti 1.2.32\n" | ||
| "Project-Id-Version: Cacti \n" |
Member
Author
|
Closing for now: the title change itself is correct and clean, but plugin_syslog's develop branch currently has pre-existing Plugin Integration Test failures (DashboardDefaultTest, SetupModuleBoundaryTest) unrelated to this one-line change, so CI cannot go green here yet. Will reopen once develop is green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cacti's graph action (drilldown) menu now renders each registered button's
titleas a visible text label. With that change, this plugin's graph button title "Display Syslog in Range" reads as an overlong entry in the menu.This shortens it to Syslog, matching the concise, label-style wording of the other drilldown actions. The existing
fas fa-exclamation-triangleglyph is unchanged and already follows the preferrediconLink+ Font Awesome drilldown format.Changes
includes/navigation.php—syslog_graph_buttons(): titleDisplay Syslog in Range→Syslog.locales/po/cacti.pot— regenerated for the removed translatable string (required by the i18n gate;Syslogalready exists as a msgid).CHANGELOG.md— entry underdevelop.Testing
php -l includes/navigation.php— clean.php tests/bin/check-i18n-pot.php origin/develop— OK (pot included).includes/navigation.phpis in the patch-coverage$unmeasured_allowlist, so no measured lines change.