Repository navigation
Conversation
bd66fc6 to
7a0de47
Compare
|
hey! can you please get this to a 5/5? |
Persist mute state per timeline segment instead of per clip, so splitting a segment lets each half be muted independently. Centralizes the mute check in the audio renderer for normal-speed, retimed, and transition audio, and threads audioMuted through Cap-project import so it isn't lost when appending a muted segment into another project.
7a0de47 to
71a1a26
Compare
|
Hey @richiemcilroy, could you re-run Greptile on this? I've fixed the import regression it flagged and added a test covering it, so it should score 5/5 now. |
|
hey @greptileai please re-review the pr |
Manage your Superagent protectionSuperagent has paused scans for this repository because this unlinked GitHub App installation has used all three included PR scans. You have 0 of 3 included PR scans remaining. Create a free account to continue protection, manage scan settings, review security history, and control which repositories are protected. |
7cb1213 to
0afab1b
Compare
|
Closing this PR as superseded by changes already in
The original behavior requested in #2109 is already implemented, so this PR's additional |
Summary
Fixes #2109.
After splitting a recording clip, each resulting timeline segment keeps its own persisted mute state. Muting a segment preserves its selected pitch/speed processing mode, and unmuting restores that mode. Existing projects remain compatible, including clips muted using
speedAudioMode.Changes
mainand integrate segment muting with the current Solid and GPUI clip menus, volume controls, and cursor settings.audioMutedin preview, normal and retimed rendering, and the streaming export path, including both sides of transitions.Validation
Passed locally:
cargo check -p cap-project --lockedcargo test -p cap-project --lib— 140 teststsc --project apps/desktop/tsconfig.json --noEmit)git diff --checkAdded regression coverage for segment isolation, retimed mute, streaming exports with crossfade/fade-through-black, active playback refresh, preparation validation, split/unmute behavior, merge preservation, and import preservation.
Native validation is incomplete locally:
cargo test -p cap-editor --lib segment_muteandcargo check -p cap-desktop --all-targetsstop in thecidredependency because this Mac has Command Line Tools but no full Xcode installation. Editor, backend/import, and GPUI native tests still need CI validation. No manual UI/audio playback verification was performed.