Skip to content

Fix method names - #51

Merged
sfluegel05 merged 4 commits into
devfrom
fix/method-names
Sep 1, 2026
Merged

sfluegel05 merged 4 commits into
devfrom
fix/method-names

Conversation

@sfluegel05

Copy link
Copy Markdown
Contributor

Reimplementing the fix from #50 (but this time based on the v1.2.0 release that works with chebai 1.4.0)

@sfluegel05
sfluegel05 merged commit d349427 into dev Sep 1, 2026
2 of 3 checks passed
@sfluegel05
sfluegel05 deleted the fix/method-names branch September 1, 2026 09:30
@aditya0by0

aditya0by0 commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

@sfluegel05, Could you please let me know the reason why DataPropertiesSetter is duplicated again in chebi.py file, even though its already present in base.py. We could import and re-use. Similary GraphPropertiesMixIn and GraphPropAsPerNodeType were also duplicated.

Also the ruff/pre-commit flaged the same error and this PR was merged despite of that.

Fix which was introduced in https://github.com/ChEB-AI/python-chebai-graph/pull/50/files worked for me, for prediction pipeline.

This is now fixed in #48

aditya0by0 added a commit that referenced this pull request Oct 27, 2026
Reference:
Also be PR can be abandoned and closed
#53
@sfluegel05

Copy link
Copy Markdown
Contributor Author

I am not sure about the details since this happened a while ago, but merging this PR was probably a mistake on my part.

We should keep the DataPropertiesSetter out of chebi.py going forward. Since that is the case in #48, that should solve the problem.

This branch was successfully deployed

1 active deployment
pypi — ba65b804 Deployed Sep 1, 2026 by sfluegel05 via pypi-publish #9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants