Repository navigation
fix(queries): fixed fp on terraform/aws network acl with unrestricted access to rdp/ssh queries - #8151
Open
cx-ricardo-jesus wants to merge 3 commits into
Open
fix(queries): fixed fp on terraform/aws network acl with unrestricted access to rdp/ssh queries#8151cx-ricardo-jesus wants to merge 3 commits into
cx-ricardo-jesus wants to merge 3 commits into
Conversation
Contributor
|
KICS version: v2.1.20
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Proposed Changes
Network ACL With Unrestricted Access to RDPandNetwork ACL With Unrestricted Access to RDPfor Terraform / AWS were reporting a false positive when theprotocolfield was defined totcp, an open CIDR (e.g.,"cidr_block": "0.0.0.0/0") and bothfrom_portandto_portset both to0.Proposed Changes
is_tcp_port_zeroto both queries to stop the query from returning a result when the scenario described above occurs.positive4.tfthat covered that specific scenario was renamed tonegative6.tfsince this case shouldn't return any result.I submit this contribution under the Apache-2.0 license.