Repository navigation
feat: replace reconciles by WarningsPollInterval with custom event source - #367
Open
GrigoryPervakov wants to merge 1 commit into
Open
GrigoryPervakov wants to merge 1 commit into
GrigoryPervakov wants to merge 1 commit into
Conversation
GrigoryPervakov
force-pushed
the
cluster-observer
branch
from
October 20, 2026 15:03
901181a to
cbf208b
Compare
GrigoryPervakov
marked this pull request as ready for review
October 20, 2026 15:05
GrigoryPervakov
force-pushed
the
cluster-observer
branch
from
October 20, 2026 15:22
cbf208b to
6dae8ce
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The warnings-reporting feature triggers a full reconciliation every few seconds. Config reload is detected only by polling during reconciliation; this will trigger reconciliation earlier.
Keeper status can be stale if the most recent reconciliation was long ago.
What
Custom event source for the keeper/clickhouse controllers that queues reconciliations if the observable state of the cluster has changed.
EventSource caches the last result and emits an event only when the result changes.