mctpd: Remove downstream peers when bridge node is removed

[potinlai]

Currently, remove_bridged_peers() checks 'if (!sources)' and returns
early if bridge_ep_poll.sources is NULL. The sources array is only
allocated when periodic bridge endpoint polling is enabled.

However, downstream endpoints within the allocated bridge pool range
can still be discovered and added to the network via the LearnEndpoint
D-Bus method (or static assignment) even when periodic polling is not
active.

When a bridge node is removed, the early return in
remove_bridged_peers() causes the pool iteration loop to be skipped if
polling was inactive. As a result, downstream node EID objects remain
registered in mctpd and published on D-Bus as orphaned endpoints.

Fix this by:

1. Replacing the early 'if (!sources) return 0;' check with network
   validation ('if (!n) return -EPROTO;').
2. Guarding polling timer teardown with 'if (sources && sources[idx])'.

This ensures remove_bridged_peers() always iterates across the bridge's
allocated pool range [pool_start, pool_end] and invokes remove_peer() on
all existing downstream node EID objects when the parent bridge node is
removed.

[potinlai]

Gentle ping on this review.
Please kindly let me know if any concerns of the changes.

[jk-ozlabs]

Are you able to add a test case to cover this?

[potinlai]

Are you able to add a test case to cover this?

Test case added, please have a review.
Thank you.

[jk-ozlabs]

Test case added, please have a review. Thank you.

Nice one, thanks! I'll check it out.

[jk-ozlabs]

I have merged this, with a minor change to the testcase formatting (and ordering within the file), but github has not detected this as a merge. Closing manually, thanks for the contribution!