Repository navigation
fix: do not send didSave notification once the client is disposed - #101
Merged
Merged
Conversation
The InitializeTextDocumentFeature awaits writeFile before sending the didSave notification. If the manager is disposed (or the client stopped) in the meantime, languageClient is undefined and sendNotification throws "Cannot read properties of undefined (reading 'sendNotification')" as an unhandled rejection.
CGNonofr
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
InitializeTextDocumentFeaturesaves every opened document withawait infrastructure.writeFile(...)and then sendstextDocument/didSave. If the manager is disposed whilewriteFileis still running (for example when the editor switches to another file and the old client is torn down),dispose()has already setlanguageClienttoundefined. The nextsendNotificationthen throws as an unhandled rejection:clear()disposes theonDidOpenTextDocumentlistener, but it doesn't stop a save that's already running.Fix
After
writeFileresolves, return early if the underlying client is gone. That covers both the disposed case and the stopped-and-restarting case.Testing
npm run lintpasses, andnpm run compilesucceeds with the guard indist/extensions.js.npm testfails in the same 3Infrastructuretests with and without this change, so those failures already exist onmain.