Repository navigation
Conversation
- The cache key was built before the current module was known. With useModuleRoot, two modules asking for the same file name shared the first module's path. The module is now part of the key. - The manifest was stored under one key and looked up under another, so the manifest file was read from disk again on every lookup that was not already cached. - When a file was not in the manifest, the first call returned the full path but a different value was cached, so later calls returned the bare file name. Each fix has a spec that fails without it.
homestar9
marked this pull request as ready for review
October 27, 2026 22:34
elixirPath() runs for every asset on every page. A cache hit now builds a plain string key and does one struct lookup, instead of serializing the arguments to JSON and hashing them. The request context and current module are only looked up when the module root is used, and the leading slash cleanup, a regex, only runs on a cache miss.
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HTMLHelper.elixirPath()remembers the paths it has already worked out. Three mistakes in how it does that:useModuleRoot = true, the cache key was built before the current module was known. The module is now part of the key./includes/js/custom.jsbut cachedjs/custom.js. The full path is now cached.Jira Issues
https://ortussolutions.atlassian.net/browse/COLDBOX-1474
Part of https://ortussolutions.atlassian.net/browse/COLDBOX-1478
Type of change
Checklist
Tests
tests/specs/integration/HTMLHelperElixirSpec.cfc(new): one spec for each problem above.All 3 new specs fail on the 8.3.0 code. With the fix, every spec in the changed files passes on BoxLang (CFML compat), Lucee 5 and Adobe 2025.