Repository navigation
Conversation
Collaborator
|
Thank you for the clear report and the fix. I'm closing this because no service the package calls returns camelCase properties. On 2026-10-13 the queryables of all 39 Water Data OGC collections and all 6 NGWMN collections were snake_case, so the rename in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicit OGC
properties=["sampleTime"]request currently returns nosample_timecolumn when the response uses camel-case fields._finalize_ogcnormalizes the response column, but_arrange_colsstill selects using the original property name.Normalize the requested names through the same helper before selecting output columns. The existing
idalias and geometry handling stay in place, and the caller's property list is unchanged. Add an offline regression test that checks the returned value and column name.Validation on the current upstream
main:python -m pytest tests/waterdata_utils_test.py -qpassed 112 tests (4 environment-dependent skips), andpython -m pytest tests/waterdata_test.py -qpassed 115 tests (1 deselected). Fixes #437.