refactor(ogc): declare date parameters on the dialect and read them on entry (ADR 0014, step 2)

[thodson-usgs]

Step 2 of ADR 0014 (proposed). Stacked on #448: this branch includes #448's three commits. Review only the last commit, 5a9a0490; I'll rebase once #448 merges.

Problem

The shared OGC code still named Water Data's facts:

• the request builder listed its seven date parameters (_DATE_RANGE_PARAMS);
• the request builder exempted last_modified by name from date-only writing;
• the chunk planner repeated the seven date parameters in _NEVER_CHUNK, and a test checked that the two lists matched.

Change

• OgcDialect:
  • New field date_params, defaulting to {"datetime"}, the standard's one date parameter.
  • New field timed_params.
  • date_only_services is renamed date_only_collections, because it is keyed by collection (see the CONTEXT.md note).
  • The Water Data dialect lists its seven date parameters and sets timed_params={"last_modified"}.
• prepare_request_args(..., dialect=) reads the dialect's date parameters into a DateRange when the getter is called, and drops a range with both ends open.
  • Water Data's _get_args passes WATERDATA_DIALECT. The Samples and Statistics getters pass None, because those APIs are not OGC.
  • NGWMN passes NGWMN_DIALECT.
• get_ogc_data reads any date parameter that is still raw, which is the case for a get_reference_table(query=...) dict. It raises TypeError for a DateRange under a key the dialect does not list, which would otherwise be sent as its repr.
• The chunk planner lists no date parameter, since a DateRange is not a list. _DATE_RANGE_PARAMS is removed.
• New architecture test: test_protocol_code_names_nothing_a_dialect_declares fails if a string a shipped dialect lists appears as a literal in ogc/ or _intervals.py.
  • It found one: the "value" default of _normalize_str_iterable's param_name, which matches Water Data's value column. param_name is now required.
  • monitoring_location_id is the one allowlisted literal; ADR 0014 records it as a known departure.

Behavior

• The values sent are unchanged.
• An unreadable date now raises when the getter is called, rather than when the first request is built. The message is the same.
• No NEWS entry, since nothing a caller sees changes.

Tests

• New tests:
  • prepare_request_args reads dates on entry, and reads none without a dialect;
  • a DateRange under an unlisted key raises;
  • get_reference_table(query={"last_modified": ...}) reads and writes the date, and drops [None, None];
  • the planner never splits a DateRange.
• Results:
  • The offline suite (1334 tests) passes under UTC, America/Chicago and Asia/Kolkata.
  • Coverage is 99.01%.
  • The pre-commit gates pass.
  • The live tests that send dates (daily, water level, reference, ratings, and the dialect tests) pass.

Next

Step 3: Service and Endpoint, and the service-name architecture test.

🤖 Generated with Claude Code

https://claude.ai/code/session_01HBt3Ee7eneKtdKQWq2T3YK

[thodson-usgs]

Combined into #448, which now holds all three ADR 0014 steps as one commit each.