Repository navigation
fix(testnet): pin DOS Names to the canonical JASJ deployment - #271
Conversation
DOS_NAMES_TESTNET_SUBGRAPH_REF (and the dependency-build pin) pointed at DOS Names 130d42ae, whose dos-testnet-3939.json described the retired 2EhC chain. Its smokeResolver has no code on the canonical JASJ chain, so the testnet Apply pre-flight stopped there. DOS Names 3345d09e (DOS/DOS-Names-Contracts#10) restores the JASJ record (deployed 2026-08-12, blocks 120-166) and records the score-gated domain policy deployed on 2026-10-21. Only the testnet pin moves; the mainnet pin is unchanged. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
If your organization's extra usage balance is empty, an organization admin can add extra usage credits at claude.ai/admin-settings/usage. If its monthly spend limit was reached, an admin can raise it on the same page. If neither applies, contact Anthropic support.
Once extra usage is available, someone with write access to this repository can comment @claude review on this pull request to trigger a review.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: updating the testnet DOS Names pin to the canonical JASJ deployment. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (2 skipped: 2 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
![dos[bot]](https://avatars.githubusercontent.com/in/4711427?s=60&v=4){kind=small}
Summary
DOS_NAMES_TESTNET_SUBGRAPH_REF(deploy-config) andDOS_NAMES_SUBGRAPH_REF(dependency-build) from130d42aeto3345d09e(fix: point DOS Testnet at the canonical JASJ chain DOS-Names-Contracts#10 merge).130d42aecarried ados-testnet-3939.jsonfor the retired chain 2EhC. Its smokeResolver has no code on the canonical chain JASJ (genesis0x36f98b2e...), so the testnet Apply pre-flight failed.3345d09erestores the JASJ record (blocks 120-166) and adds adomainPolicyblock for the score-gated policy deployed on 2026-10-21.contracts.dosRegistrarintentionally keeps the retired public registrar, because the pre-flight requires that key.Verification
python -m pytest .github/scripts/tests/test_validate_testnet_bens.py: 36 passed.Known gap (follow-up)
The DOS Names subgraph still indexes
NameRegistered/NameRenewedonly fromcontracts.dosRegistrar. Registrations through the new policy registrar remain visible through the registryLabelRegistered/ExpiryUpdatedevents, but their registrar metadata is not indexed.🤖 Generated with Claude Code
📌 TL;DR
This PR updates the
DOS_NAMES_SUBGRAPH_REFandDOS_NAMES_TESTNET_SUBGRAPH_REFenvironment variables in GitHub Actions workflows and corresponding tests to point to a new subgraph commit (3345d09...). This ensures that dependency builds and testnet deployments use the latest version of the DOS Names subgraph.🎯 Type of Change
🔍 Changes Walkthrough
.github/scripts/tests/test_validate_testnet_bens.pyDOS_NAMES_TESTNET_SUBGRAPH_REFvalue in the test fixture to match the new subgraph commit hash..github/workflows/dependency-build.ymlDOS_NAMES_SUBGRAPH_REFenvironment variable to the new commit hash for dependency builds..github/workflows/deploy-config.ymlDOS_NAMES_TESTNET_SUBNET_SUBGRAPH_REFenvironment variable to the new commit hash for testnet deployment configurations.📊 Architectural Flow
flowchart TD A[PR Update] --> B[Update Subgraph Refs in CI Configs] B --> C[dependency-build.yml] B --> D[deploy-config.yml] B --> E[test_validate_testnet_bens.py] C --> F[Build Dependencies using New Subgraph] D --> G[Deploy Testnet Config using New Subgraph] E --> H[Validate Testnet Deployment Logic] F --> I[CI Pipeline Execution] G --> I H --> ISummary by CodeRabbit