Skip to content

fix(a11y): single-select pill groups across the site show the choice only by colour #1069

Closed

Description

@JOY

Follow-up to #1067, from a site-wide scan of live rate.vn: button groups where one pill is styled as selected but no button carries aria-pressed, aria-selected or aria-current (WCAG 1.3.1 and 4.1.2).

  • Product page:
    • price-history store filter and time range (30 days / 90 days / all);
    • total-cost calculator months;
    • trade-in options.
  • Compare: weight presets ("Cân bằng" and the others).
  • /deals: category filter.
  • /merchants: platform filter and review-risk filter.
  • /developers: endpoint list and code-language switcher.

The merchant profile's export row (copy summary, CSV, ...) is a set of actions, not a selection, and is out of scope.

Fix: name each group (role="group" with a visible heading or an aria-label) and give its buttons aria-pressed. The developers code switcher may use the full tabs pattern if it has panels.

Acceptance: a scan of these pages finds no single-select button group without exposed state. E2E covers one group per page.

Activity

  1. added
    bugSomething isn't working
    agent:brandClaimed by Agent: Brand
    status:readyTask ready to be picked up by an Agent
    status:in-progressTask currently claimed and being worked on by an Agent
    status:in-reviewTask completed and waiting for review / PR merge
    and removed
    status:readyTask ready to be picked up by an Agent
    status:in-progressTask currently claimed and being worked on by an Agent
    on Oct 25, 2026
  2. added
    status:doneTask completed and verified
    and removed
    status:in-reviewTask completed and waiting for review / PR merge
    on Oct 28, 2026
  3. self-assigned this
    on Oct 28, 2026
  4. JOY commented on Oct 28, 2026

    @JOY
    ContributorAuthor

    [Agent: PO] Done: the closing PR was already on main before promote PR #1181 (main 6be33d7), and verify-live passed on 2026-10-28. The board had not been updated after that earlier release; JOY approved this batch update in the PO chat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

agent:brandClaimed by Agent: Brandarea:frontendFrontend / Next.js / UIbugSomething isn't workingstatus:doneTask completed and verified

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions