Skip to content

fix(a11y): catalog "view all deals" link is a 21px-tall tap target #1075

Closed
#1076
Closed
fix(a11y): catalog "view all deals" link is a 21px-tall tap target#1075
#1076
Assignees
JOY
Labels
agent:brandClaimed by Agent: Brandarea:frontendFrontend / Next.js / UIbugSomething isn't workingstatus:doneTask completed and verified

Description

@JOY
JOY (JOY)
opened on Oct 25, 2026

From a WCAG 2.2 target-size scan of live rate.vn at 375px (SC 2.5.8, minimum 24×24 px unless spaced or inline). Across the home, catalog, product, compare, deals, merchants and leaderboard pages, the only failing target is the catalog deal-radar link "Xem tất cả deal trên 10 sàn". It is 21px tall, and a 24px circle centred on it overlaps a neighbouring target.

Fix: give .rate-radar-spread-head > a a 24px minimum height (it is already inline-flex and centred).

Acceptance: the link is at least 24px tall, and the scan finds no undersized target. E2E covers it.

Activity

  1. JOY (JOY)
    added
    bugSomething isn't working
    area:frontendFrontend / Next.js / UI
    agent:brandClaimed by Agent: Brand
    status:in-progressTask currently claimed and being worked on by an Agent
    status:in-reviewTask completed and waiting for review / PR merge
    and removed
    status:in-progressTask currently claimed and being worked on by an Agent
    on Oct 25, 2026
  2. JOY (JOY)
    added a commit that references this issue on Oct 25, 2026

    fix(a11y): make the catalog deal-radar link a 24px target (#1075) (#1076

    ecc4c06
  3. JOY (JOY)
    closed this as completedin #1076on Oct 25, 2026
  4. JOY (JOY)
    added
    status:doneTask completed and verified
    and removed
    status:in-reviewTask completed and waiting for review / PR merge
    on Oct 28, 2026
  5. JOY (JOY)
    self-assigned this
    on Oct 28, 2026

  6. JOY commented on Oct 28, 2026

    @JOY
    JOY (JOY)
    on Oct 28, 2026
    ContributorAuthor

    [Agent: PO] Done: the closing PR was already on main before promote PR #1181 (main 6be33d7), and verify-live passed on 2026-10-28. The board had not been updated after that earlier release; JOY approved this batch update in the PO chat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

agent:brandClaimed by Agent: Brandarea:frontendFrontend / Next.js / UIbugSomething isn't workingstatus:doneTask completed and verified

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions