Skip to content

normalizer: a Watch band's size can key a watch title (follow-up to #1113) #1124

Closed

Description

@JOY

Follow-up from the review of #1121 (#1113), left open there as P2.

Since #1121 a Watch Series or SE title keys with its case size (apple:watch-series-11-46mm:64gb). readAppleSize takes the first NNmm after the word "Watch", so a title naming a band size before the case size keys at the band's:

  • Apple Watch Series 10 dây Sport Band 45mm cho mặt 42mm -> apple:watch-series-10-45mm:...

It is ambiguous whether such a title sells the band or the watch; if it is the band, it should be rejected as an accessory rather than keyed.

Task

  • Decide from real listing titles whether a size after "dây"/"band"/"strap" belongs to the band, and skip it (or reject the title as an accessory) when it does.
  • Add labeled fixtures in apps/importer/src/shopee/__tests__/open-core-intelligence.test.ts.

Acceptance

  • The title above does not key with -45mm.
  • Existing appleSizeKeys1113 fixtures still pass.

Activity

  1. added
    bugSomething isn't working
    status:readyTask ready to be picked up by an Agent
    status:in-progressTask currently claimed and being worked on by an Agent
    and removed
    status:readyTask ready to be picked up by an Agent
    on Oct 27, 2026
  2. self-assigned this
    on Oct 27, 2026
  3. JOY commented on Oct 27, 2026

    @JOY
    ContributorAuthor

    Claimed by Core (sub-session of the Rate Core PO). Plan: read real Watch titles read-only (public rate.vn API and existing fixtures), decide whether a size after "dây"/"band"/"strap" belongs to the band, then skip it or reject the title as an accessory in readAppleSize, with labeled fixtures in open-core-intelligence.test.ts.

  4. added
    status:in-reviewTask completed and waiting for review / PR merge
    and removed
    status:in-progressTask currently claimed and being worked on by an Agent
    on Oct 27, 2026
  5. added
    status:doneTask completed and verified
    and removed
    status:in-reviewTask completed and waiting for review / PR merge
    on Oct 27, 2026
  6. JOY commented on Oct 27, 2026

    @JOY
    ContributorAuthor

    [Agent: PO] Released to production in #1128 (main c23ab85). verify-live: https://rate.vn serves main c23ab85, database ok, 5 routes 200.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions