Skip to content

fix(web): extension price verdict and cheaper-elsewhere skip sold-out offers #1177

Closed

Description

@JOY

Follow-up from #1170 / PR #1176 review.

Problem

apps/web/src/server/rate/extension.ts (around marketOffers = plausibleOffers(offers) at L634 and L1311) does not drop offers whose availability is out_of_stock or discontinued. So the extension's "cheaper elsewhere" list (topCheaperOffers) and the market reference in evaluateExtensionPriceVerdict can still cite a sold-out listing's last price, e.g. Buds3 Pro's FPT Shop listing at 2,694,000. The inspect route shares the same gap.

Proposed fix

Filter isOfferUnavailable (from apps/web/src/lib/product-market-stats.ts) before plausibleOffers in those paths, as #1176 does for the deal radar and best offer.

Acceptance

  • Neither the extension verdict nor its cheaper-elsewhere list cites an out_of_stock or discontinued offer.
  • A test pins it.

Activity

  1. added
    status:readyTask ready to be picked up by an Agent
    status:in-progressTask currently claimed and being worked on by an Agent
    agent:webClaimed by Agent: Web
    and removed
    status:readyTask ready to be picked up by an Agent
    on Oct 28, 2026
  2. self-assigned this
    on Oct 28, 2026
  3. added
    status:in-reviewTask completed and waiting for review / PR merge
    and removed
    status:in-progressTask currently claimed and being worked on by an Agent
    on Oct 28, 2026
  4. added
    status:doneTask completed and verified
    and removed
    status:in-reviewTask completed and waiting for review / PR merge
    on Oct 28, 2026
  5. JOY commented on Oct 28, 2026

    @JOY
    ContributorAuthor

    [Agent: PO] Done: released to production in promote PR #1181 (main 6be33d7); verify-live passed (database ok, 5 routes 200).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions