Skip to content

[SVLS-9963] chore(bottlecap): upgrade libddwaf, zstd, and serverless-components - #1467

Open
litianningdatadog wants to merge 2 commits into
mainfrom
tianning.li/SVLS-9963-libddwaf-zstd-upgrade
Open

litianningdatadog wants to merge 2 commits into
mainfrom
tianning.li/SVLS-9963-libddwaf-zstd-upgrade

Conversation

@litianningdatadog

@litianningdatadog litianningdatadog commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Overview

Upgrades zstd to 0.14.3 and libddwaf/libddwaf-sys to 2.1.0, updates Bottlecap AppSec for the libddwaf 2.1 API, enables its AWS-LC downloader provider, and refreshes the affected third-party license notices.

Also updates Bottlecap to serverless-components commit fd24c365ade64078b697e00f57f823aff32a65f7 (DataDog/serverless-components#196). This updates datadog-opentelemetry to 0.5.4 and aligns direct libdatadog package pins with that dependency line. Bottlecap code is adapted to the corresponding propagation, trace processing, HTTP-client configuration, and span-statistics API changes.

Jira: https://datadoghq.atlassian.net/browse/SVLS-9963

Testing

  • cargo fmt --check
  • cargo check --all-targets
  • Focused lifecycle and trace test suites
  • Integration-test target compilation (--no-run)
  • cargo tree -e features --no-default-features --features fips -i ring (no ring found)
  • Verified the updated zstd package metadata declares BSD-3-Clause.

Copilot AI balanced review requested due to automatic review settings October 28, 2026 15:39
@litianningdatadog
litianningdatadog requested a review from a team as a code owner October 28, 2026 15:39
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-29T18:09:14.876097Z 4856b50 New commits
🔒 Security Review ✅ Completed 2026-10-29T18:10:18.605468Z 4856b50 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-prod-us1-3

datadog-prod-us1-3 Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4856b50 | Docs | View more details | Give us feedback!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the dependency upgrades and AppSec API migration.

No open issues 🎉

What changed in this PR

Updates Bottlecap’s compression and WAF dependencies, adapting its AppSec integration to libddwaf 2.1.

Changes:

  • Upgrades zstd to 0.14.3 and libddwaf/libddwaf-sys to 2.1.0, enabling AWS-LC for WAF binary downloads.
  • Migrates AppSec initialization, execution, and object handling to the updated WAF API.
  • Updates integration-test expectations for WAF version lookup and numeric array indices in trigger output.
File Description
bottlecap/​tests/​appsec_processor_test.rs Updates version lookup and expected trigger JSON.
bottlecap/​src/​appsec/​processor/​mod.rs Adapts WAF initialization and diagnostics types.
bottlecap/​src/​appsec/​processor/​context.rs Migrates WAF execution, serialization, and collection construction.
bottlecap/​Cargo.toml Updates dependency versions and enables the downloader’s AWS-LC provider.
bottlecap/​Cargo.lock Records updated dependencies and transitive resolution changes.

Review effort: Balanced

@litianningdatadog
litianningdatadog force-pushed the tianning.li/SVLS-9963-libddwaf-zstd-upgrade branch 4 times, most recently from cba1d45 to 98a7959 Compare October 29, 2026 16:57
@litianningdatadog litianningdatadog changed the title [SVLS-9963] chore(bottlecap): upgrade libddwaf and zstd [SVLS-9963] chore(bottlecap): upgrade libddwaf, zstd, and serverless-components Oct 29, 2026
@litianningdatadog
litianningdatadog requested a review from a team as a code owner October 29, 2026 16:57
@litianningdatadog
litianningdatadog force-pushed the tianning.li/SVLS-9963-libddwaf-zstd-upgrade branch 2 times, most recently from 205f0a3 to c8515aa Compare October 29, 2026 17:56
@litianningdatadog
litianningdatadog force-pushed the tianning.li/SVLS-9963-libddwaf-zstd-upgrade branch from c8515aa to 1a11a4b Compare October 29, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants