Repository navigation
[SVLS-9963] chore(bottlecap): upgrade libddwaf, zstd, and serverless-components - #1467
Open
litianningdatadog wants to merge 2 commits into
Open
litianningdatadog wants to merge 2 commits into
litianningdatadog wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
litianningdatadog
force-pushed
the
tianning.li/SVLS-9963-libddwaf-zstd-upgrade
branch
from
October 28, 2026 15:41
c8b4070 to
bb0f175
Compare
|
This comment will be updated automatically if new data arrives. 🔗 Commit SHA: 4856b50 | Docs | View more details | Give us feedback! |
lym953
approved these changes
Oct 28, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the dependency upgrades and AppSec API migration.
No open issues 🎉
What changed in this PR
Updates Bottlecap’s compression and WAF dependencies, adapting its AppSec integration to libddwaf 2.1.
Changes:
- Upgrades zstd to 0.14.3 and libddwaf/libddwaf-sys to 2.1.0, enabling AWS-LC for WAF binary downloads.
- Migrates AppSec initialization, execution, and object handling to the updated WAF API.
- Updates integration-test expectations for WAF version lookup and numeric array indices in trigger output.
| File | Description |
|---|---|
bottlecap/tests/appsec_processor_test.rs |
Updates version lookup and expected trigger JSON. |
bottlecap/src/appsec/processor/mod.rs |
Adapts WAF initialization and diagnostics types. |
bottlecap/src/appsec/processor/context.rs |
Migrates WAF execution, serialization, and collection construction. |
bottlecap/Cargo.toml |
Updates dependency versions and enables the downloader’s AWS-LC provider. |
bottlecap/Cargo.lock |
Records updated dependencies and transitive resolution changes. |
Review effort: Balanced
litianningdatadog
force-pushed
the
tianning.li/SVLS-9963-libddwaf-zstd-upgrade
branch
4 times, most recently
from
October 29, 2026 16:57
cba1d45 to
98a7959
Compare
litianningdatadog
force-pushed
the
tianning.li/SVLS-9963-libddwaf-zstd-upgrade
branch
2 times, most recently
from
October 29, 2026 17:56
205f0a3 to
c8515aa
Compare
litianningdatadog
force-pushed
the
tianning.li/SVLS-9963-libddwaf-zstd-upgrade
branch
from
October 29, 2026 17:58
c8515aa to
1a11a4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Upgrades zstd to 0.14.3 and libddwaf/libddwaf-sys to 2.1.0, updates Bottlecap AppSec for the libddwaf 2.1 API, enables its AWS-LC downloader provider, and refreshes the affected third-party license notices.
Also updates Bottlecap to serverless-components commit
fd24c365ade64078b697e00f57f823aff32a65f7(DataDog/serverless-components#196). This updates datadog-opentelemetry to 0.5.4 and aligns direct libdatadog package pins with that dependency line. Bottlecap code is adapted to the corresponding propagation, trace processing, HTTP-client configuration, and span-statistics API changes.Jira: https://datadoghq.atlassian.net/browse/SVLS-9963
Testing
cargo fmt --checkcargo check --all-targets--no-run)cargo tree -e features --no-default-features --features fips -i ring(no ring found)BSD-3-Clause.