Skip to content

Disable unittest and selenium to fix error log - #873

Merged
rithikanarayan merged 1 commit into
mainfrom
rithika.narayan/unittest-error-log
Oct 21, 2026
Merged

rithikanarayan merged 1 commit into
mainfrom
rithika.narayan/unittest-error-log

Conversation

@rithikanarayan

@rithikanarayan rithikanarayan commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Patch now turns off unittest and selenium, two modules from CI Viz, which were emitting error logs due to CI Viz being removed from the layer. Now that they are turned off, we do not try to patch modules that do not exist in the Lambda layer.

Also changes the incorrect paths of some of the modules stripped in the Dockerfile to the correct path.

Motivation

#871

Testing Guidelines

Tested for logs on a real lambda.
Logs with published layer 127, contains line failed to enable ddtrace support for unittest: No module named 'ddtrace.internal.ci_visibility'
Logs with custom layer from this PR, no error line.

Additional Notes

Types of Changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Disabling unittest and selenium patching is consistent with stripping their CI Visibility dependencies from the Lambda layer. Runtime behavior remains unverified because the review environment lacked ddtrace.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit d57b9c2

@rithikanarayan
rithikanarayan merged commit 7366ffe into main Oct 21, 2026
106 checks passed
@rithikanarayan
rithikanarayan deleted the rithika.narayan/unittest-error-log branch October 21, 2026 16:38

@purple4reina purple4reina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants