Repository navigation
Disable unittest and selenium to fix error log - #873
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
More details
Disabling unittest and selenium patching is consistent with stripping their CI Visibility dependencies from the Lambda layer. Runtime behavior remains unverified because the review environment lacked ddtrace.
🤖 Bits Code Review · Commit d57b9c2
jcstorms1
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Patch now turns off unittest and selenium, two modules from CI Viz, which were emitting error logs due to CI Viz being removed from the layer. Now that they are turned off, we do not try to patch modules that do not exist in the Lambda layer.
Also changes the incorrect paths of some of the modules stripped in the Dockerfile to the correct path.
Motivation
#871
Testing Guidelines
Tested for logs on a real lambda.
Logs with published layer 127, contains line
failed to enable ddtrace support for unittest: No module named 'ddtrace.internal.ci_visibility'Logs with custom layer from this PR, no error line.
Additional Notes
Types of Changes
Check all that apply