Repository navigation
chore: exclude stacktrace C extension's new location - #875
emmettbutler wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
More details
The removal glob targets the relocated compiled extension while preserving the security modules needed at startup. The retained legacy path also covers older ddtrace layouts; no reportable defect was identified.
🤖 Bits Code Review · Commit e2c2dff
|
@emmettbutler I am currently doing a release for this layer, please don't merge this until at least tomorrow afternoon (assuming this ddtrace change is going out in 4.17 or later, if it's already out pls let me know asap and I'll pause the release) 🙏 |
rithikanarayan
left a comment
There was a problem hiding this comment.
blocking til release is done, dm if the comment about ddtrace version this responds to is relevant
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 1 Pipeline job failed
ℹ️ Info🔄 Datadog auto-retried 1 job - 0 passed on retry Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: e2c2dff | Docs | View more details | Give us feedback! |
dd-trace-py is moving its stacktrace C extension, which only IAST uses, from
ddtrace/appsec/_shared/toddtrace/internal/security/. The layer already stripsddtrace/appsec/_sharedfor this reason. The new directory also contains modules AAP imports at startup, so only the compiled extension is removed, not the whole directory.The existing
ddtrace/appsec/_sharedentry is kept so the layer still strips the extension from ddtrace versions released before the move.rm -rfignores whichever path doesn't exist, so this works with both old and new ddtrace versions, and the merge order relative to the dd-trace-py change doesn't matter.Testing Guidelines
The extension isn't imported at serverless startup; dd-trace-py's
tests/internal/test_serverless.pyasserts this at its new module path.Additional Notes
Types of Changes
Check all that apply
🤖 Generated with Claude Code