Skip to content

Report debugger telemetry metrics in the debugger namespace - #12892

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
watson/DEBUG-6335/debugger-telemetry-namespace
Oct 16, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
masterfrom
watson/DEBUG-6335/debugger-telemetry-namespace

Conversation

@watson

@watson watson commented Oct 15, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The debugger team agreed that every tracer reports its debugger metrics in a shared debugger instrumentation telemetry namespace instead of live_debugger.

 // DebuggerMetricCollector.DebuggerMetric (events.skipped, events.dropped)
-private static final String NAMESPACE = "live_debugger";
+private static final String NAMESPACE = "debugger";

The intake allows the new namespace since ddoghq/dd-go#23524. DataDog/system-tests#8052 adds a cross-tracer test for it.

Evidence

  • Before: DebuggerMetricCollectorTest asserts metric.namespace == "live_debugger".
    After: it asserts metric.namespace == "debugger". I couldn't run the Gradle build locally, so CI is the first run.

Merge Danger

Door: two-way

Blast Radius: internal

Only internal telemetry changes. The intake change (ddoghq/dd-go#23524) is merged; it must be deployed before a release containing this ships, because until then the intake rejects generate-metrics payloads that contain debugger series.

Jira ticket: DEBUG-6335

🤖 Generated with Claude Code

The debugger team agreed to report all debugger metrics in a `debugger`
instrumentation telemetry namespace, shared by every tracer, instead of
`live_debugger`.

Environment: Datadog workspace

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@watson watson added type: bug fix Bug fix tag: no release notes Changes to exclude from release notes comp: debugger Dynamic Instrumentation tag: ai generated Largely based on code generated by an AI or LLM labels Oct 15, 2026
@watson
watson marked this pull request as ready for review October 15, 2026 16:06
@watson
watson requested a review from a team as a code owner October 15, 2026 16:06
@watson
watson requested review from P403n1x87 and removed request for a team October 15, 2026 16:06
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T16:07:54.047266Z cbbd732 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-15T16:09:26.988440Z cbbd732 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-official datadog-official Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bits Code Review: PASS

More details

Both debugger metric types receive the shared debugger namespace, and the telemetry pipeline forwards it without restrictions. Release compatibility depends on the intake support described in the PR being deployed.

Was this helpful? React 👍 or 👎

Open Bits AI session

🤖 Bits Code Review · Commit cbbd732

@datadog-official

This comment has been minimized.

@dd-octo-sts

dd-octo-sts Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 14.02 s 13.93 s [-0.1%; +1.3%] (no difference)
startup:insecure-bank:tracing:Agent 12.88 s 12.94 s [-1.1%; +0.2%] (no difference)
startup:petclinic:appsec:Agent 17.11 s 17.08 s [-0.7%; +1.1%] (no difference)
startup:petclinic:iast:Agent 16.97 s 17.09 s [-1.4%; +0.1%] (no difference)
startup:petclinic:profiling:Agent 16.74 s 16.42 s [-2.5%; +6.4%] (no difference)
startup:petclinic:sca:Agent 17.02 s 17.03 s [-1.0%; +0.9%] (no difference)
startup:petclinic:tracing:Agent 16.24 s 16.08 s [-0.2%; +2.2%] (no difference)

Commit: cbbd732f · CI Pipeline · Benchmarking Platform UI


Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@watson
watson enabled auto-merge October 15, 2026 16:48
@watson
watson added this pull request to the merge queue Oct 15, 2026
@dd-octo-sts

dd-octo-sts Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-10-15 16:53:32 UTC ℹ️ Start processing command /merge


2026-10-15 16:53:36 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in master is approximately 1h (p90).


2026-10-15 17:11:05 UTC ⚠️ MergeQueue: This merge request build was cancelled

thomas.watson@datadoghq.com cancelled this merge request build

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 15, 2026
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 7634ad8 into master Oct 16, 2026
832 of 844 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the watson/DEBUG-6335/debugger-telemetry-namespace branch October 16, 2026 10:52
@github-actions github-actions Bot added this to the 1.68.0 milestone Oct 16, 2026
watson added a commit to DataDog/system-tests that referenced this pull request Oct 20, 2026
Ruby 2.46.0 reports its debugger metrics in the `debugger` namespace
(DataDog/dd-trace-rb#6484), and Java's change (DataDog/dd-trace-java#12892)
is merged, so enable the test for Ruby from 2.46.0 and for Java from the
1.68.0 snapshots. Both use the weblogs where the line-probe snapshot tests
run, since this test installs a line snapshot probe.

Environment: Datadog workspace

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: debugger Dynamic Instrumentation tag: ai generated Largely based on code generated by an AI or LLM tag: no release notes Changes to exclude from release notes type: bug fix Bug fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants