Repository navigation
fix: retry Test Visibility installation - #75
Conversation
|
/datadog autotest review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 069df0f858
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
There was a problem hiding this comment.
The wget fallback now rejects BusyBox installations because of an unsupported retry option. The regression script also fails when run as root because temporary workspace cleanup leaves a dangling shared symlink.
🤖 Bits Code Review · Commit 069df0f
|
/datadog autotest review |
|
Codex Review: Something went wrong. Try again later by commenting “@codex review”. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
There was a problem hiding this comment.
More details
Retries preserve failure exit codes after three attempts, and failed installer output is excluded from GITHUB_ENV. The completed static review identified no reportable regression.
🤖 Bits Code Review · Commit af30669
|
@codex review |
|
Codex Review: Didn't find any major issues. You're on a roll. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
juan-fernandez
changed the title
There was a problem hiding this comment.
More details
Failed installer attempts do not publish environment output, and exhausted retries still fail the action. Static analysis and isolated retry probes found no reportable regression; the hosted installer was not exercised.
🤖 Bits Code Review · Commit af30669
2 participants
What does this PR do?
Retries the installer download and configuration script up to three times, with 2- and 4-second backoff. HTTP errors now fail the curl download. GNU wget's own retry count is limited when its help advertises the option; minimal wget implementations retain the portable invocation.
Checksum verification remains mandatory. Environment output is captured separately for each installer attempt and appended to GITHUB_ENV only after a successful run.
Motivation
Fixes #74. Transient connection resets and upstream/registry failures currently fail the workflow when the download or installer exits unsuccessfully, even when rerunning the job succeeds.
Additional Notes
The hosted v15 installer is unchanged. Retrying its execution covers failures from tracer artifact downloads and package-manager installs, including failures after npm exhausts its own HTTP retries.
Possible Drawbacks / Trade-offs
Retries also apply to permanent download/install failures, adding up to two attempts and six seconds of backoff per phase. Retrying a multi-language installation reruns earlier successful language installs.
Describe how to test/QA your changes
Run
python3 scripts/test-install-retries.py. The test uses Python's standard-library HTTP server and executes the action's shell step with a small fixture installer. It covers recovery from download and installer failures, the three-attempt limit for each phase, and discarding environment output from failed attempts.Validation:
git diff --checkpassed.The same regression test is added to CI alongside the existing Java and Go smoke tests.