Repository navigation
[sharedb] Add 'retry' middleware action - #75750
Draft
dawidreedsy wants to merge 1 commit into
Draft
dawidreedsy wants to merge 1 commit into
dawidreedsy wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the new
'retry'middleware action from share/sharedb#761 tomiddleware.ActionContextMap.retryis triggered when an op loses the race to commit, before it is retried against a newer snapshot. Middleware can use it to reset state stored on the request during the failed attempt. It receives the sameSubmitRequestas the other submit actions, so it is typed asSubmitContext(with no$fixup, which is only valid in'apply').sharedb-tests.tsadds"retry"to the submit-related actions loop, plus a check that$fixupisn't allowed in it.Draft until share/sharedb#761 is merged and released. The version in
package.jsonwill need bumping to match that release if it ships as a minor.pnpm test <package to test>.If changing an existing definition:
retrymiddleware action share/sharedb#761package.json. (pending the sharedb release)cc @alecgibson @ericyhwang
🤖 Generated with Claude Code