fix(docx): hold a composed chip's row less the borders both editors draw outside it - #800
Merged
Merged
Conversation
…el, and where a chip's padding holds its top border
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CobaltRota's staff rows each stood up to 1.1pt taller in Word than on the page, and its last row 6.5pt low.holdRowAtLeast).What changed
writePanelPiece. The borders drawn outside the row's height (bordersOutside) are now computed once, before the two branches that hold a panel's row, and the composed-outline branch takes them off as the placed-panel branch already did.holdRowAtLeastalready takes off.verticalMarginsJavadoc. It now says the other border of a panel's own cell comes off inwritePanelPiece, where its padding does not hold its top border.CHANGELOG.md, the composed-shape paragraph ofdocs/recipes/docx-export.md, and the composed-cell sentence ofdocs/architecture/backend-capability-matrix.md.Verification
./mvnw -B -ntp clean verify -pl :graph-compose-core,:graph-compose-render-pdf,:graph-compose-render-docx,:graph-compose-render-pptx,:graph-compose-templates,:graph-compose-testing,:graph-compose-qa,:graph-compose-coverage -amgives BUILD SUCCESS (1791 + 127 tests).DocxComposedCellTest.anOutlinedChipHoldsItsRowLessBothBorders(new).2.5-dev: onlyCobaltRotachanges. It stays one page.Known limits
ObsidianInvoice, Word median 0.25pt → 0.49), and no template places a block under a chip.Lane: shared-engine (render-docx). No public API change.