test(qa): hold the DOCX fidelity baseline to the lines #804 sets where the page does - #806
Merged
Merged
Conversation
…e the page does
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The DOCX fidelity baseline (#805) was taken before #804 merged. #804 sets lines where the page breaks them in documents of sizes Word rounds to the half point, and the baseline did not yet hold those lines. Nothing stopped them moving back.
What changed
qa/src/test/resources/docx-fidelity/libreoffice-windows*.tsv, rewritten with-Dgraphcompose.docxFidelity.update=trueon2.5-devate6bf2210c(test(qa): hold every template's DOCX export to a line-by-line corpus baseline #805 on fix(docx): break a paragraph's lines where the page does, though Word sets its size to the half point #804).EngineeringResume(+10 found, 14 → 0 lines past 2pt),NordicClean(+5, 21 → 0),BlueBanner(+10),CompactMono(+8) andSerifHeadline(+8, 7 → 0).Verification
./mvnw -B -ntp test -f qa/pom.xml -Dtest=DocxFidelityCorpusTest -Dgraphcompose.docxFidelity=libreofficeagainst the new baseline gives BUILD SUCCESS../mvnw -B -ntp clean verify -pl :graph-compose-core,:graph-compose-render-pdf,:graph-compose-render-docx,:graph-compose-render-pptx,:graph-compose-templates,:graph-compose-testing,:graph-compose-qa,:graph-compose-coverage -amgives BUILD SUCCESS (qa 1809).Lane: test (qa). Baseline data only.