Repository navigation
feat: update tiled node insertion structure - #1669
Open
ZohebShaikh wants to merge 10 commits into
Open
ZohebShaikh wants to merge 10 commits into
ZohebShaikh wants to merge 10 commits into
Conversation
ZohebShaikh
added this pull request to stack #1670
September 11, 2026 10:44
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1669 +/- ##
==========================================
+ Coverage 96.36% 96.41% +0.05%
==========================================
Files 49 49
Lines 3686 3711 +25
==========================================
+ Hits 3552 3578 +26
+ Misses 134 133 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ZohebShaikh
force-pushed
the
tiled-path-change
branch
2 times, most recently
from
September 11, 2026 14:45
4414034 to
abcd7ff
Compare
ZohebShaikh
commented
Sep 11, 2026
| diamond-policies: | ||
| service: ghcr | ||
| resource: ghcr.io/diamondlightsource/authz-policy:0.0.24 | ||
| resource: ghcr.io/zohebshaikh/authz-policy:0.0.25-alpha |
Contributor
Author
There was a problem hiding this comment.
@fajinyuan Here is the PR in authz that needs to be merged before this gets in.
Once merged in authz I will release and change here
There was a problem hiding this comment.
There is no description or context to guide reviewers on this related PR.
ZohebShaikh
force-pushed
the
tiled-path-change
branch
2 times, most recently
from
September 11, 2026 15:35
b5295b6 to
cf72900
Compare
ZohebShaikh
force-pushed
the
tiled-path-change
branch
2 times, most recently
from
September 11, 2026 15:49
0a60f5b to
a0df79b
Compare
ZohebShaikh
force-pushed
the
tiled-path-change
branch
from
September 11, 2026 15:49
a0df79b to
a5635b9
Compare
ZohebShaikh
marked this pull request as ready for review
September 16, 2026 08:10
ZohebShaikh
force-pushed
the
tiled-path-change
branch
from
September 17, 2026 10:04
a5635b9 to
5b5bb6f
Compare
tpoliaw
reviewed
Sep 17, 2026
tpoliaw
left a comment
tpoliaw
left a comment
Contributor
There was a problem hiding this comment.
I don't really know how the authorization stuff for tiled works but it looks plausible.
The amount of stuff going on in the begin_task is starting to look a bit suspect though. Can be a later PR but is it possible offload some of it to the tiled writer or client?
ZohebShaikh
force-pushed
the
tiled-path-change
branch
from
October 6, 2026 13:59
5b5bb6f to
fb20712
Compare
ZohebShaikh
force-pushed
the
tiled-path-change
branch
from
October 14, 2026 22:39
fb20712 to
2b60c20
Compare
abbiemery
approved these changes
Oct 15, 2026
fajinyuan
requested changes
Oct 16, 2026
| diamond-policies: | ||
| service: ghcr | ||
| resource: ghcr.io/diamondlightsource/authz-policy:0.0.24 | ||
| resource: ghcr.io/zohebshaikh/authz-policy:0.0.25-alpha |
There was a problem hiding this comment.
why do you need change the resource path to a personal one?
There was a problem hiding this comment.
There is not enough information in referenced PR for me to understand the reason for this personalised path in URL
begin_task checked and opened each of beamline, proposal and visit in turn, six requests before every run, and built a new tiled client (server info plus a token) for every task. Look up beamline/proposal/visit in one request, and only walk the levels when it is missing: create each, falling back to opening it on a 409. Reuse one service-account client across tasks; a client carrying a caller's pass-through headers is still made per task. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tiled in the system tests now runs ghcr.io/zohebshaikh/dls-tiled, which ships the DLS access policy (dls_tiled.policy), instead of a copy of that policy mounted into the stock tiled image; that copy and its unit tests are removed, along with the tiled[minimal-server] dev dependency only they used. OPA moves to authz-policy 0.0.27-alpha, which grants access at the level it is held. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
edge-static-debug floated with every OPA build. Pin 1.21.2, the version authz now builds and tests its policy with; the debug variant is kept because entrypoint.sh needs a shell. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
0.0.28-alpha is built from authz 452bd95: the same decisions as 0.0.27-alpha, with the policy written for OPA 1.21.2 (string interpolation, so it needs OPA 1.x to load). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬