Repository navigation
Conversation
- Add `mrtLoadingState` and `skipWhileSkeleton` to `DiamondDSIntegrations` - Add `mrtRowIntent` to tint rows with an intent's container colour, keeping hover and selected states visible - Document loading and row emphasis for MRT and plain tables - Show a warning row paired with a status chip in the Table story and dev app
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds shared MRT helpers to
DiamondDSIntegrations, with docs.mrtLoadingState(loading, data)shows skeleton rows on first load and a progress bar on refetch, never both. An empty array counts as no data.skipWhileSkeleton(callback)skips row, cell and checkbox style callbacks while skeletons show, so placeholder rows aren't styled.mrtRowIntent(intent)tints a row with the intent'scontainercolour and keeps hover and selected states visible. Use it sparingly and always with a status chip or icon.Also adds a Loading section and a Row emphasis section to the MRT guidance, a Row emphasis section to the Table guidance, a
WarningRowstory, and a warning row in the dev app.Skeleton (as seen on i15-1)
Warning row (as seen on Dev App)
