Repository navigation
feat(workflows user interface): add button to stop workflows - #1705
Merged
Merged
Conversation
Oli-Jones475
force-pushed
the
stop-workflows-button
branch
2 times, most recently
from
October 6, 2026 15:27
6c42038 to
86574c3
Compare
Oli-Jones475
requested review from
JamesDoingStuff and
hazdl
and removed request for
hazdl
October 6, 2026 15:45
hazdl
reviewed
Oct 6, 2026
hazdl
reviewed
Oct 6, 2026
hazdl
reviewed
Oct 6, 2026
Oli-Jones475
force-pushed
the
stop-workflows-button
branch
6 times, most recently
from
October 7, 2026 11:03
fb40975 to
205082a
Compare
hazdl
reviewed
Oct 8, 2026
hazdl
reviewed
Oct 8, 2026
hazdl
requested changes
Oct 8, 2026
hazdl
left a comment
Contributor
There was a problem hiding this comment.
I added 2 comments to consider.
Create stop workflows button Only show stop button if workflow is stoppable Add error messages when unsucessful Disable button after its been clicked fix(worfklows user interface): clear error on successful cancellation fix(workflows user interface): set loading on request
Oli-Jones475
force-pushed
the
stop-workflows-button
branch
from
October 8, 2026 13:56
e831011 to
6a3a605
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a button to stop workflows. Only show up if the workflow is stoppable (running or pending). Error message included in tooltip.
The button was added to the bottom of the expanded accordion view. It would make more sense to put it next to the other buttons in the accordion header. However, those are classed as links by MUI since they take you to another page. The accordion header is already a button so putting another button in there causes errors. There are more in depth solutions possible but the UI is being reworked anyway.