Skip to content

feat(workflows user interface): add button to stop workflows - #1705

Merged
Oli-Jones475 merged 1 commit into
mainfrom
stop-workflows-button
Oct 8, 2026
Merged

Oli-Jones475 merged 1 commit into
mainfrom
stop-workflows-button

Conversation

@Oli-Jones475

Copy link
Copy Markdown
Contributor

Added a button to stop workflows. Only show up if the workflow is stoppable (running or pending). Error message included in tooltip.

The button was added to the bottom of the expanded accordion view. It would make more sense to put it next to the other buttons in the accordion header. However, those are classed as links by MUI since they take you to another page. The accordion header is already a button so putting another button in there causes errors. There are more in depth solutions possible but the UI is being reworked anyway.

@Oli-Jones475
Oli-Jones475 force-pushed the stop-workflows-button branch 2 times, most recently from 6c42038 to 86574c3 Compare October 6, 2026 15:27
@Oli-Jones475
Oli-Jones475 requested review from JamesDoingStuff and hazdl and removed request for hazdl October 6, 2026 15:45
Comment thread frontend/relay-workflows-lib/lib/mutation-components/StopWorkflow.tsx Outdated
Comment thread frontend/relay-workflows-lib/lib/mutation-components/StopWorkflow.tsx Outdated
Comment thread frontend/relay-workflows-lib/lib/mutation-components/StopWorkflow.tsx Outdated
@Oli-Jones475
Oli-Jones475 force-pushed the stop-workflows-button branch 6 times, most recently from fb40975 to 205082a Compare October 7, 2026 11:03
@Oli-Jones475
Oli-Jones475 requested review from hazdl and removed request for hazdl October 7, 2026 11:54

@hazdl hazdl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added 2 comments to consider.

@Oli-Jones475
Oli-Jones475 requested a review from hazdl October 8, 2026 13:18

@hazdl hazdl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

Create stop workflows button

Only show stop button if workflow is stoppable

Add error messages when unsucessful

Disable button after its been clicked

fix(worfklows user interface): clear error on successful cancellation

fix(workflows user interface): set loading on request
@Oli-Jones475
Oli-Jones475 force-pushed the stop-workflows-button branch from e831011 to 6a3a605 Compare October 8, 2026 13:56
@Oli-Jones475
Oli-Jones475 merged commit 7d07a4e into main Oct 8, 2026
71 checks passed
@Oli-Jones475
Oli-Jones475 deleted the stop-workflows-button branch October 8, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants