Skip to content

fix(workflows): use larger argo page size for client-side filtering - #1712

Merged
hazdl merged 1 commit into
mainfrom
hz/para-filter-limit
Oct 8, 2026
Merged

hazdl merged 1 commit into
mainfrom
hz/para-filter-limit

Conversation

@hazdl

@hazdl hazdl commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Analysis Platform - AP-1366

Fixes inefficient workflow filtering when filtering by parameters or annotations.

Previously, the GraphQL limit was also used as the Argo API page size. This meant that a small GraphQL limit, such as limit: 10, could cause many Argo API requests when searching through a large number of workflows with few or no matches.

The client-side filtering path now uses a separate Argo page size of 1000 workflows per request.

The GraphQL limit remains unchanged and continues to control the maximum number of matching workflows returned to the user.

Changes

  • Added a dedicated Argo workflow page size of 1000.
  • Kept the GraphQL limit independent from the Argo page size.

Testing

  • cargo fmt --check
  • cargo clippy -p graph-proxy --all-targets --all-features
  • cargo test -p graph-proxy graphql::workflows::tests::multiple_workflows_query_with_annotation_filter -- --nocapture

@davehadley davehadley left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove all of the spurious files that have been added to this PR?

eg backend/graph-proxy/condensed-matter,

@hazdl
hazdl force-pushed the hz/para-filter-limit branch from 4c8449d to fa52351 Compare October 8, 2026 13:05
@hazdl

hazdl commented Oct 8, 2026

Copy link
Copy Markdown
Contributor Author

Fixed it. I removed the spurious files. When I last added workflows.rs, these files were unexpectedly created as part of the change, although I'm not sure why. I've cleaned them up now, and the PR contains only the intended change to backend/graph-proxy/src/graphql/workflows.rs.

@hazdl
hazdl requested a review from davehadley October 8, 2026 13:40
@hazdl
hazdl merged commit 60ac89a into main Oct 8, 2026
71 checks passed
@hazdl
hazdl deleted the hz/para-filter-limit branch October 8, 2026 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants