Skip to content

Don't spend an in-flight credit when nothing was sent #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mathieucarbou merged 2 commits into from
Oct 12, 2026
Merged

Don't spend an in-flight credit when nothing was sent #488

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc365cc
Don't spend an in-flight credit when nothing was sent
MitchBradley Oct 9, 2026
a23ade1
Merge branch 'main' into FixInFlightCreditStall
mathieucarbou Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/WebResponses.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -499,8 +499,14 @@ size_t AsyncAbstractResponse::write_send_buffs(AsyncWebServerRequest *request, s
request->client()->send();
_writtenLength += payloadlen;
#if ASYNCWEBSERVER_USE_CHUNK_INFLIGHT
_in_flight += payloadlen;
--_in_flight_credit; // take a credit
// Take a credit only for data actually put in flight. When the source
// had nothing yet (RESPONSE_TRY_AGAIN), nothing will be acked to return
// the credit, and polls don't return credits, so spending one here would
// stall the response for good once the credits run out.
if (payloadlen) {
_in_flight += payloadlen;
--_in_flight_credit; // take a credit
}
#endif
if (_send_buffer_len == 0) {
// buffer empty, we can release mem, otherwise need to keep it till next run (should not happen under normal conditions)
Expand Down
Loading