Skip to content

feat(installer): require Windows 10 or later #1005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asdf80730 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(installer): require Windows 10 or later #1005

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions installer/installer.nsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,12 +181,6 @@ Function .onInit
Abort
${EndIf}

; Currently, we're not able to support Windows xp since it has an incomplete TSF.
${IfNot} ${AtLeastWinVista}
MessageBox MB_ICONSTOP|MB_OK $(AtLeastWinVista_MESSAGE)
Quit
${EndIf}

; The installer is an x86 (32-bit) binary. On 64-bit Windows (x64 and ARM64),
; the WOW64 subsystem automatically redirects all registry writes to WOW6432Node.
; Enable 64-bit registry view globally so NSIS registry commands (WriteRegStr,
Expand All @@ -197,6 +191,21 @@ Function .onInit
SetRegView 64
${EndIf}

; Windows 10 is the minimum supported OS. The runtime payload sets the
; floor: the bundled Python, Go and Rust runtimes require Windows 10, and
; Node 22 supports 8.1 only as experimental.
; Check this before the pending-reboot prompt so an unsupported system
; fails before any old version is removed. Keep the AtLeastWin8 feature
; gates below unchanged: they control optional components, not the floor.
${IfNot} ${AtLeastWin10}
MessageBox MB_ICONSTOP|MB_OK $(AtLeastWin10_MESSAGE)
Quit
${EndIf}

; Nothing to check for the C runtime: Windows 10 ships the UCRT in-box, and
; PIME ships no VC++ redistributable (the launcher and C++ DLLs are static
; and the Python embed carries its own vcruntime140.dll).

; Check if an earlier uninstallation or update scheduled locked files or directories
; to be deleted on reboot. If so, reinstalling before rebooting will cause Windows
; Session Manager to wipe the newly installed files on the next restart.
Expand Down
2 changes: 1 addition & 1 deletion installer/locale/English.nsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
!insertmacro LANG_STRING PRODUCT_PAGE "PIME project home page"
!insertmacro LANG_STRING PRODUCT_PUBLISHER "PIME development team"

!insertmacro LANG_STRING AtLeastWinVista_MESSAGE "Sorry，this program currently only supports Windows Vista or later"
!insertmacro LANG_STRING AtLeastWin10_MESSAGE "Sorry，this program currently only supports Windows 10 or later"
!insertmacro LANG_STRING REBOOT_QUESTION "The installation failed and could no be completed.$\r$\nA file may be in use, that prevents it from being deleted or overwritten.$\n$\nIt is recommended that you reboot the system and run the installer again.$\r$\nDo you want to reboot now? (Select $\"No$\" if you want to reboot at a later time)"
!insertmacro LANG_STRING PENDING_REBOOT_QUESTION "A previous uninstallation or update of PIME requires a system restart to complete.$\r$\n$\r$\nIf you proceed without restarting, newly installed files may be deleted on the next reboot.$\r$\n$\r$\nDo you want to restart your computer now? (Select $\"No$\" to exit setup and restart later)"
!insertmacro LANG_STRING INST_FAILED_MESSAGE "The installation failed and could no be completed.$\n$\rA file may be in use, that prevents it from being deleted or overwritten.$\n$\nIt is recommended that you reboot the system and run the installer again."
Expand Down
2 changes: 1 addition & 1 deletion installer/locale/SimpChinese.nsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
!insertmacro LANG_STRING PRODUCT_PAGE "PIME 项目主页"
!insertmacro LANG_STRING PRODUCT_PUBLISHER "PIME 开发团队"

!insertmacro LANG_STRING AtLeastWinVista_MESSAGE "抱歉，本程序目前只能支持 Windows Vista 以上版本"
!insertmacro LANG_STRING AtLeastWin10_MESSAGE "抱歉，本程序目前只能支持 Windows 10 以上版本"
!insertmacro LANG_STRING REBOOT_QUESTION "安装发生错误，无法完成。$\r$\n有时是有文件正在使用中，暂时无法删除或覆写。$\n$\n建议重新开机后，再次执行安装程序。$\r$\n你要立即重新开机吗？ (若你想要在稍后才重新开机请选择「否」)"
!insertmacro LANG_STRING PENDING_REBOOT_QUESTION "先前的 PIME 卸载或更新尚未完成，需要重新启动计算机。$\r$\n$\r$\n如果未重启就继续安装，新安装的文件可能会在下次开机时被系统删除。$\r$\n$\r$\n您要现在重新启动计算机吗？（选“否”将退出安装程序，以便稍后重启）"
!insertmacro LANG_STRING INST_FAILED_MESSAGE "安装发生错误，无法完成。$\n$\n有时是有文件正在使用中，暂时无法删除或覆写。$\n$\n建议重新开机后，再次执行安装程序。"
Expand Down
2 changes: 1 addition & 1 deletion installer/locale/TradChinese.nsh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
!insertmacro LANG_STRING PRODUCT_PAGE "PIME 專案網頁"
!insertmacro LANG_STRING PRODUCT_PUBLISHER "PIME 開發團隊"

!insertmacro LANG_STRING AtLeastWinVista_MESSAGE "抱歉，本程式目前只能支援 Windows Vista 以上版本"
!insertmacro LANG_STRING AtLeastWin10_MESSAGE "抱歉，本程式目前只能支援 Windows 10 以上版本"
!insertmacro LANG_STRING REBOOT_QUESTION "安裝發生錯誤，無法完成。$\r$\n有時是有檔案正在使用中，暫時無法刪除或覆寫。$\n$\n建議重新開機後，再次執行安裝程式。$\r$\n你要立即重新開機嗎？ (若你想要在稍後才重新開機請選擇「否」)"
!insertmacro LANG_STRING PENDING_REBOOT_QUESTION "先前的 PIME 解除安裝或更新尚未完成，需要重新啟動電腦。$\r$\n$\r$\n如果未重新開機便繼續安裝，新安裝的檔案可能會在下次開機時被系統刪除。$\r$\n$\r$\n您要現在重新啟動電腦嗎？（選「否」將結束安裝程式，以便稍後重新開機）"
!insertmacro LANG_STRING INST_FAILED_MESSAGE "安裝發生錯誤，無法完成。$\n$\n有時是有檔案正在使用中，暫時無法刪除或覆寫。$\n$\n建議重新開機後，再次執行安裝程式。"
Expand Down