Repository navigation
Conversation
server.go imported input_methods/fcitx5 and input_methods/simple_pinyin, which no branch contains, so the main package could not compile. Remove both registrations and their integration tests; unknown ime.json directories are now logged and left unregistered instead of falling back to a missing package. Fully generated by omp (DeepSeek V4.1 Flash) without human intervention.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go backend does not compile as published:
server.goimportsinput_methods/fcitx5andinput_methods/simple_pinyin, and no branch in thisrepository contains either package, so
go build ./...fails on the mainpackage. CI does not build the Go backend, which is why this went unnoticed.
loadInputMethodsregistrations.ime.jsondirectories are now logged and left unregistered insteadof silently falling back to the missing
simple_pinyinpackage.Validation:
go build ./...on master fails withserver.go:18:2andserver.go:21:2"no required module provides package ..." and passes with this change
(go 1.25.14, windows/arm64).
go test ./...passes:pime-go,input_methods/meow,input_methods/rime,pime.CGO_ENABLED=0 GOOS=windows GOARCH=386 go build ./...passes.
Fully generated by omp (DeepSeek V4.1 Flash) without human intervention.