Repository navigation
Enable cpplint and copyright linters - #27
Merged
Merged
Conversation
Remove the lines that disabled ament_cmake_cpplint and ament_cmake_copyright, and fix what they report: header guards, include order, missing includes, using-directives in tests, C types and casts, comment spacing, and two remaining GPL headers moved to the Apache header of the rest of the project. Humble's ament_copyright does not recognize the license when the header has the EasyNav line, so copyright is skipped only there. Fixes #26 Signed-off-by: Francisco Martín Rico <fmrico@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26
Enables
ament_cmake_cpplintandament_cmake_copyrightin every package (theset(ament_cmake_*_FOUND TRUE)lines are removed), and fixes what they report:NAVMAP_CORE__GEOMETRY_HPP_,NAVMAP_CORE__NAVMAP_HPP_,NAVMAP_RVIZ_PLUGIN__NAVMAPDISPLAY_HPP_).<utility>includes.using namespace navmap;in tests replaced by using-declarations.unsigned short→uint16_t, a C-style cast,explicitconstructor, range-for spacing, comment spacing,elsebraces.NavMap.hppandtest_navmap_assign.cppstill had the old GPL header: now the Apache 2.0 header of the rest of the project (the package license). The launch filenavmap_to_occgrid.launch.pygets its header.test_navmap_io.cpp: indentation of the last test and a duplicatedremove(path).test_conversions.cpp: lambda spacing that uncrustify reported in every distro.Humble's
ament_copyrightdoes not recognize the Apache license when the header has the line This file is part of the project Easy Navigation, so copyright is skipped only whenROS_DISTROishumble.Checked with cpplint, copyright and uncrustify of humble, jazzy, kilted, lyrical and rolling (cpplint 0 and copyright 0 in all; uncrustify on humble keeps its pre-existing version differences), and
colcon build/colcon teston rolling.