Repository navigation
build(ios): find the Crashlytics script where Flutter puts packages - #642
Merged
Merged
Conversation
|
✅ OpenCodeReview: Review skipped: no items were selected. |
lowrt
approved these changes
Oct 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
whes1015
force-pushed
the
fix/ios-crashlytics-script
branch
from
October 22, 2026 00:29
a265242 to
551c9a3
Compare
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
這個 PR 做了什麼
修正 #631 加的 Crashlytics build phase:它寫死去
${BUILD_DIR%/Build/*}/SourcePackages(DerivedData)找Crashlytics/run,但 Flutter 驅動的建置一律傳-clonedSourcePackagesDirPath build/ios/SourcePackages(ios.yml的註解也寫了這點),所以那裡沒有這個檔案,script 找不到就讓整個建置失敗:受影響的是所有經過 Flutter 的 iOS 建置:
tool/run.sh(iOS 實機或模擬器)、flutter build ios,以及 CI 的Test (ios/RunnerTests)(tool/dev/test_ios.sh)。#641 的 iOS 檢查就是這樣失敗的(run)。#638、#639 沒失敗,是因為它們沒改到ios/、lib/、assets/,iOS job 被路徑過濾跳過了。release workflow 的xcodebuild archive沒有傳那個參數,套件放在 DerivedData,所以 release 一直是正常的。改動內容
正式程式碼
ios/Runner.xcodeproj/project.pbxproj:Crashlytics build phase 的 scriptRelease上傳 dSYM。Debug和Profile(tool/run.sh、RunnerTests)直接結束:這些建置不會出貨,沒有需要符號化的東西,也應該能離線建置。firebase-ios-sdk/Crashlytics/run:先找 DerivedData(release workflow 的 archive),再找${SRCROOT}/../build/ios/SourcePackages(Flutter 驅動的建置)。測試
沒有新增測試。這是 Xcode build phase,用下面的方式驗證。
相關 issue
接續 #631。
怎麼驗
plutil -extract … raw),用假的目錄結構跑四種情況:CONFIGURATION=Debug:直接 exit 0。plutil -lint通過。tool/dev/test_ios.sh:419 個測試全過。修正前同樣的步驟會在這個 build phase 失敗。tool/commit.sh --push全部通過。檢查清單
tool/check/commits.sh origin/main..HEAD通過tool/commit.sh --push),iOS 原生測試 419 個通過