Repository navigation
fix(otel): use the /otel Cloud endpoint base - #903
Conversation
|
Thanks @chhhee10 for your contribution to Failproof AI! 🙌 We'd love to discuss your PR and welcome you to our community. Discord: https://discord.befailproof.ai/ |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 38.46% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 5 files. (3 skipped: … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Title check The title clearly identifies the main change: updating the Cloud OpenTelemetry endpoint base to /otel. Description check The description is detailed and covers the change, motivation, validation, rollout requirements, compatibility behavior, and documentation. It does not use the repository template headings or checkbox…
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 38.46% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 5 files. (3 skipped: 3 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
-
📝 Generate docstrings: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
I’m a rabbit with a path to trace, /otel leads to the Cloud’s new place.
Logs and metrics follow through,
Traces join the signal queue.
Local paths stay as they were,
I nibble greens and hop with care.
Comment @coderabbitai help to get the list of available commands.
Hermes
No summary yet. What this changesNo component map for this revision. RoundsNo review has finished on this pull request yet. FindingsNothing raised yet.
|
Hermes
No correctness, security, or compatibility defect found. Cloud-bound OTLP configuration and relay forwarding consistently target What this changesflowchart LR
n0OTELCLIconfiguration["~ OTEL CLI configuration"]
n1AgentOTELsettingswriters["~ Agent OTEL settings writers"]
n2LocalOTLPrelay["~ Local OTLP relay"]
n3CloudOTLPingestAPI["Cloud OTLP ingest API"]
n4OTELregressiontests["~ OTEL regression tests"]
n5OTELuserdocumentation["~ OTEL user documentation"]
n0OTELCLIconfiguration -- "constructs exporter settings" --> n1AgentOTELsettingswriters
n1AgentOTELsettingswriters -- "uses /otel signal endpoints" --> n3CloudOTLPingestAPI
n1AgentOTELsettingswriters -- "uses local /v1 endpoints" --> n2LocalOTLPrelay
n2LocalOTLPrelay -- "forwards /otel/v1 batches" --> n3CloudOTLPingestAPI
n4OTELregressiontests -- "asserts generated endpoints" --> n0OTELCLIconfiguration
n4OTELregressiontests -- "asserts upstream paths" --> n2LocalOTLPrelay
Rounds
FindingsNothing raised yet.
|
hermes-exosphere
left a comment
hermes-exosphere
left a comment
There was a problem hiding this comment.
Hermes found no blocking issues in this revision.
3 participants
Companion PR: FailproofAI/agenteye#1080
Summary
Follow-up to merged #880. Direct agent configuration and
otel envnow use<cloud>/otel. Codex gets the complete<cloud>/otel/v1/logsURL. The daemon keeps standard local/v1/*receivers and SDK spool metadata, and forwards upstream to/otel/v1/*exactly once.Cloud credentials and non-OTLP API URLs are unchanged. Existing beta direct-agent settings are reported as not managed until rewritten. After upgrading, disable/re-enable OTel and restart the agent to load the new settings.
Validation
Rollout
Requires the companion AgentEye namespace PR to be deployed first. Generic Collector endpoint:
<cloud>/otel; per-signal endpoint:<cloud>/otel/v1/<signal>. No compatibility aliases requested.Version stays 1.0.11. No release, publish or deploy performed. Public usage docs and CHANGELOG are included. Existing
otel_enabled/otel_disabledtelemetry remains unchanged and covers the setup actions; no new customer data is collected.Hermes review
f78d19e73bc7092ffa32c1db6b4b0f0d5245f5e11d8f31d926828f3bae215c58f5b35baa44acbff0gpt-5.6-terraSummary
No correctness, security, or compatibility defect found. Cloud-bound OTLP configuration and relay forwarding consistently target
/otel, while local receivers retain standard/v1/<signal>paths.Changes
otel envto use the Cloud OTLP base URL<origin>/otel; Codex and per-signal variables receive full signal URLs./v1/*while forwarding upstream to/otel/v1/*.Validation
Passeddocker run --rm --network none -v /review/input/workspace:/repo:ro -w /repo oven/bun:latest bun build src/hooks/otel-cli.ts src/hooks/otel-writers.ts --outdir /tmp/otel-syntax --external '*'— Both changed TypeScript entry points bundled successfully in an isolated container. (0s)Skippeddocker run ... bun install --frozen-lockfile --ignore-scripts && bunx vitest run __tests__/hooks/otel.test.ts --reporter=verbose— A clean dependency install remained stalled for over two minutes without materializing dependencies, so the targeted Vitest suite could not start in this isolated environment. (157s)Findings
None.
Open questions
None.
Policy overrides
None.
Summary by CodeRabbit
Bug Fixes
/otelendpoint. Local relay paths remain unchanged.Documentation
Additional local verification: 363 e2e tests passed (one skipped), and Rust clippy passed for the collector/daemon. The broad unit run had one timing-only redaction-cost failure under parallel load (8432 passed, 10 skipped); its seven-test file passed unchanged when rerun alone. The final-head CI unit matrices all passed.