Repository navigation
feat(bench): keep private question sets outside the repository - #288
Draft
tonyketcham wants to merge 1 commit into
Conversation
Two settings let the recall benchmark test a private Proof graph without its questions or answers ever entering Git: - `PROOF_RECALL_QUESTIONS` names the folder `loadQuestions` reads. - `PROOF_RECALL_RUNS` names the folder `run.mjs` and `find-recall.mjs` write run files to. With neither set, nothing changes. The README says to use such a set only as a held-out check. `run.mjs` also stops recording a dead server's pid. A run that probed a server busy loading a large graph started a second one, which was refused, yet its pid replaced the live server's, so `--stop-server` missed the live one. The probe now counts a timeout as a live server, and the pid is written only when the run's own child is the server that answers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DVVnhYL1Bz7mCfEKDoyLMW
5 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
This is layer 8 of a stack. It sits on #287.
The recall benchmark's own graph is fictional. To check that
proof findand later reads hold up on real memory, the harness must be able to ask questions about private Proof graphs. Their questions and answers must never enter this repository's Git history. This PR adds no data. It only lets the harness read and write somewhere else.PROOF_RECALL_QUESTIONSnames the folder thatloadQuestionsincheck.mjsreads. Every script loads its questions through that one function.PROOF_RECALL_RUNSnames the folder whererun.mjsandfind-recall.mjswrite run files.check.mjsstill printsok: 270 questions, 498 records, and the full Haiku comparison still prints 221.42 against 226.25.run.mjsalso stops recording a dead server's pid. Two runs started 20 seconds apart each tried to start the shared read server. The second was refused, but its pid replaced the live server's, so--stop-serverwould have missed the live server. Two changes fix this, matching #287:Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Does this introduce any non-backwards compatible changes?
Does this include any user config changes?
PROOF_RECALL_QUESTIONSandPROOF_RECALL_RUNS.Generated by Claude Code