Repository navigation
Support M64 extended format version 4 (Mupen 1.5.0-3), hotfix for Release - #79
Merged
FramePerfection merged 2 commits intoOct 16, 2026
Merged
Conversation
Mupen 1.5.0-3 (extended version 4) stores cpu_cf and rcp_lag_factor as doubles at 0x030 and 0x038. ToBytes wrote that area as zero padding, so the roundtrip check in LoadBytes threw on every movie recorded with 1.5.0-3. Read and write both fields, and write back the bytes this class doesn't model from the loaded header instead of zeros, so later additions to the format don't break loading. Fixes FramePerfection#66 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
FramePerfection
approved these changes
Oct 16, 2026
FramePerfection
left a comment
FramePerfection
left a comment
Owner
There was a problem hiding this comment.
Added the version bump myself, but lgtm.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix from #76, as a hotfix into Release, as suggested there: the same commit cherry-picked onto Release (v0.9.1), so it can ship in 0.9.2 without Development's changes. Fixes #66.
Movies recorded on Mupen 1.5.0-3 and later don't open in the M64 tab ("Specified argument was out of the range of valid values"). Extended version 4 added
cpu_cfat 0x030 andrcp_lag_factorat 0x038, whichM64Header.ToByteswrote back as zero padding, so the roundtrip check inLoadBytesfailed. This reads and writes the two fields, and writes the header bytes STROOP doesn't model back from the loaded header instead of zeros.Tested on v0.9.1 with the same change: a 1.5.0-3 movie, an extended v1 movie and a v0 movie all open, and Save leaves each byte-identical apart from the VI count. Details in #76.
🤖 Generated with Claude Code