[NopeCharon]

Summary

• the entry_before_display hook proxied $entry->content(), which appends the thumbnail and enclosures by default, and stored the result as the new content. FreshRSS then renders it with content($withEnclosures) according to the Show enclosures option of the feed, but the enclosures were already part of the content, so with the extension enabled they were shown even for feeds where that option is disabled
• only include the enclosures when the feed displays them, with the same display_enclosures logic as the FreshRSS views and APIs (e.g. index/normal.phtml, FreshRSS_Entry::toGReader(), the Fever API)
• look the feed up in the cached categories first, like the views do, to avoid one database request per entry
• when the enclosures are displayed the output is unchanged: they are still proxied and not duplicated
• bump the extension version to 1.0.4 and add a changelog entry

Validation

End-to-end with FreshRSS edge (PHP 8.5, SQLite) and a feed with a body image, an image <enclosure> and a media:thumbnail, running the entry_before_display hook and then $entry->content($feed->attributeBoolean('display_enclosures') ?? true) like index/normal.phtml:

• Show enclosures disabled, on main: the thumbnail and the enclosure are still displayed (proxied)
• Show enclosures disabled, with this change: only <p>Body <img src="https://wsrv.nl/?url=img.example%2Fbody.jpg" …></p>
• Show enclosures enabled: identical output before and after the change (body image, thumbnail and enclosure all proxied, once each)

Also composer run-script php-lint, phtml-lint, test-image-proxy, phpcs and phpstan (with ../FreshRSS).

tests/ImageProxyTest.php only covers the static URL rewriting with stubbed configuration; covering the hook would need stubs for FreshRSS_Entry, FreshRSS_Feed and FreshRSS_Category, which conflict with the real classes that PHPStan analyses, so I validated this part end-to-end instead.

[Alkarex]

Thanks!