Repository navigation
Release-gate fixes for 0.7.30: MOB_CACHE_DIR in security_scan, OTP drift check, mob ERTS preflight, stale-BEAM delete failures (MOB-493) - #153
Merged
Conversation
…rsion drift, mob ERTS preflight, failed stale-BEAM deletes fail (MOB-493)
…e otp_version on the active bundle (MOB-493)
…R and count fixes in docs (MOB-493)
Owner
Author
|
Review: Codex round 1 and round 2: DO NOT SHIP; every finding fixed. Codex then hit its usage limit (until 4:04 AM), so round 3 went to a reviewer subagent: SHIP, with one nitpick: the describe label in deployer_stale_ssl_test.exs:88 claims to cover the iOS-sim and copy_app_beams wiring, but only the helper is tested there. Accepted; not fixed in this PR. Suite: 3176/3176. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes from the 0.7.30 release-gate review (Codex,
0.7.29..master): the scan ignored MOB_CACHE_DIR; the manifest otp_version was never checked; a path/override mob < 0.9.25 built fine and died at boot; failed deletes of stale host ssl/crypto-shim BEAMs were silent; the CHANGELOG had wrong counts and a wrong 5c9c69fc claim. Its erlfmt finding read a stale checkout (master has no erlfmt). Tests: 3170/3170, credo and format clean.