Repository navigation
ci: remove pull_request_review trigger from multi-approvers workflow - #2697
Merged
Merged
Conversation
The multi-approvers action requires secrets.MULTI_APPROVERS_TOKEN. In GitHub Actions, workflows triggered by pull request events on forks (including pull_request_review) do not have access to repository secrets. When reviews are submitted on fork PRs (such as Renovate bot or external contributions), the workflow fails with "input required and not supplied: token". Removing pull_request_review aligns this workflow with the canonical configuration in googleapis/librarian and prevents failures on fork PRs.
kgala2
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the
pull_request_reviewtrigger from.github/workflows/multi-approvers.yaml.Why
The
multi-approversaction requiressecrets.MULTI_APPROVERS_TOKEN. Under GitHub Actions security restrictions, workflows triggered by pull request review events on forks do not have access to repository secrets. When reviews are submitted on fork PRs (such as external contributions or bot PRs),secrets.MULTI_APPROVERS_TOKENevaluates to empty and the action fails with:Multi-approvers action failed: input required and not supplied: token.Solution
Removing
pull_request_reviewaligns this workflow with the canonical configuration ingoogleapis/librarianand internal Cloud SDK standards (go/cloud-sdk-github-2p-reviews). For bot PRs, the initialpull_request_targetrun succeeds. For external fork PRs, approval status checks can be updated after two reviews by manually re-running thepull_request_targetcheck.