Repository navigation
ICON-eCLM: Exchange albedo and downward shortwave both radiation bands - #157
Merged
Merged
Conversation
- add global variable q_sf_grc and q_sf_patch - add ram1,rah1 and raw1 as global variables - introduce namelist parameter use_exchcoef_oascoupling - introduce exchange coefficient approach coupling - add coupling in lake landunit - fix namelist parameter use_exchcoef_oascoupling - use effective moisture resistance for raw1 at BareGroundFluxesMod.F90 - combine parallel resistances by area-weighting their conductances - guard the gridcell resistance inversion against spval and unset patches
used for downscaling in eCLM
- both models resolve a visible and a near-infrared band, which are now coupled. Send them as OASIS bundled (3D) fields instead, so the number of coupling variables and the namcouple stay unchanged - the bundle size is declared only through var_nodims(2) in oasis_def_var - replacing the artificial 50/50 split of shortwave radiation bands with the input from ICON
kvrigor
approved these changes
Oct 27, 2026
kvrigor
left a comment
kvrigor
left a comment
Member
There was a problem hiding this comment.
Good to see the use of OASIS bundled fields (a.k.a 3D coupled fields), which is only available in OASI3-MCT v5.0!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Both models resolve a visible band and a near-infrared band, whereas eCLM previously received a single broadband value, halved it, and used the same number for both. It created a bias about ~10-30%.
Changes
Stacked PR 3 of 4