Repository navigation
Conversation
aleksUIX
marked this pull request as ready for review
October 6, 2026 04:57
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deals created through
/api/v1/deals/from-templatereturn their product, price and flight details on creation, then lose them on GET because the response mapper only reads nested records.The mapper now falls back to the stored flat fields when a nested section is absent. Nested sections keep precedence, including empty sections. The booked CPM becomes
final_cpm;base_cpmstays unset when the original base price was not stored. No storage migration is needed.Regression coverage includes the real POST-to-GET route, currency conversion, zero values, existing flat records and conflicting nested values. The new regression cases failed before the change.
Validation: 1,662 unit tests passed. Integration tests: 39 passed, 28 skipped under the repository's existing conditions. Ruff lint and the repository-wide format check passed. Hosted checks passed on Python 3.11 and 3.12, along with the Docker build, secret scan and commit policy check.
Fixes #112.