Repository navigation
Conversation
Signed-off-by: lucarlig <luca.carlig@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release tagging fails when GitHub requires workflow-file write permission: the built-in
GITHUB_TOKENcannot grant it. Both attempts of CI run 38554114826 passed their build and test jobs, then failed pushingrate-limiter-v0.1.12.Use a short-lived GitHub App installation token, restricted to this repository and Contents/Workflows write permissions, for checkout and tag pushes in both CI workflows. Let the existing tag-push triggers start releases and remove the explicit dispatch to prevent duplicate release runs. Keep existing tags immutable and document how to retry an existing release.
The new dependency is GitHub's official
actions/create-github-app-tokenv3.3.0, pinned to its commit SHA (MIT licensed); it revokes the token when the job finishes. No published repository security advisories were listed when checked.Validation:
uv run --no-project --python 3.12 make plugins-validatepassed (41 tests);actionlintpassed for both changed workflows;git diff --checkpassed.Before merging, a repository or organization admin must install an approved release App on
IBM/cpex-pluginswith Contents and Workflows read/write permissions, configure Actions variableRELEASE_APP_CLIENT_IDand secretRELEASE_APP_PRIVATE_KEY, and allow the App through any applicable tag-creation rules. No release App credentials are currently configured, so the live token flow cannot yet be verified.Release recovery:
rate-limiter-v0.1.12was pushed at the exact tested commit1b4577fb92b5085c3840e1d6ce08ddc6594130bb, starting release run 38750763260. This recovery is independent of the workflow changes in this PR.