Skip to content

fix(upgrade-packages): preserve file changes across package updates - #1868

Open
georgianastasov wants to merge 1 commit into
masterfrom
ganastasov/upgrade-packages-file-save
Open

georgianastasov wants to merge 1 commit into
masterfrom
ganastasov/upgrade-packages-file-save

Conversation

@georgianastasov

Copy link
Copy Markdown
Contributor

Description

Fix upgrade-packages not saving modified files when a later package is mentioned only in a comment.

  • Preserve the fileChange flag across package updates in logic, style, and HTML files.
  • Extend existing regression tests for Angular, React, and Web Components.

Related Issue

Closes #1857

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring / code cleanup
  • Build / CI configuration change

Affected Packages

  • igniteui-cli (packages/cli)
  • @igniteui/cli-core (packages/core)
  • @igniteui/angular-templates (packages/igx-templates)
  • @igniteui/angular-schematics (packages/ng-schematics)
  • @igniteui/mcp-server (packages/igniteui-mcp)

Checklist

  • I have tested my changes locally (npm run test)
  • I have built the project successfully (npm run build)
  • I have run the linter (npm run lint)
  • I have added/updated tests as needed
  • My changes do not introduce new warnings or errors

Additional Context

  • Regression tests: 23/23 passed, with 3 failures reproduced before the fix.
  • Manual CLI verification passed for Angular, React, and Web Components.
  • Full suite: 71 pre-existing failures, verified independently of this fix.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 94.586% (+0.004%) from 94.582% — ganastasov/upgrade-packages-file-save into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade-packages: a source file is not saved when the last package name found in it has nothing to rewrite

3 participants