Skip to content

fix(upgrade-packages): update Web Components style imports - #1869

Open
georgianastasov wants to merge 1 commit into
masterfrom
ganastasov/style-imports
Open

georgianastasov wants to merge 1 commit into
masterfrom
ganastasov/style-imports

Conversation

@georgianastasov

Copy link
Copy Markdown
Contributor

Description

Fix upgrade-packages not updating style imports in Web Components projects.

  • Enable .css, .scss, and .sass file processing using the existing rewrite logic.
  • Extend existing Web Components regression tests to cover all three extensions.

Related Issue

Closes #1859

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring / code cleanup
  • Build / CI configuration change

Affected Packages

  • igniteui-cli (packages/cli)
  • @igniteui/cli-core (packages/core)
  • @igniteui/angular-templates (packages/igx-templates)
  • @igniteui/angular-schematics (packages/ng-schematics)
  • @igniteui/mcp-server (packages/igniteui-mcp)

Checklist

  • I have tested my changes locally (npm run test)
  • I have built the project successfully (npm run build)
  • I have run the linter (npm run lint)
  • I have added/updated tests as needed
  • My changes do not introduce new warnings or errors

Additional Context

  • Regression tests: 23/23 passed.
  • Manually reproduced the bug before the fix and verified the fix afterward.
  • Manual CLI tests passed for Angular, React, and Web Components.
  • Full suite: 71 failures attributed to unrelated leftover compiled test files.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@coveralls

Copy link
Copy Markdown

Coverage Status

coverage: 94.583% (+0.001%) from 94.582% — ganastasov/style-imports into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade-packages (Web Components): .css and .scss files are not rewritten, so a theme @import keeps the trial package name

3 participants